From 10eb1c9a95eedb2dfe8bcb794388f7c4d8a5ed06 Mon Sep 17 00:00:00 2001
From: Jan Tojnar <jtojnar@gmail.com>
Date: Fri, 17 Jun 2022 20:46:15 +0200
Subject: [PATCH] [FormatAbstract]: Ensure sanitizeHtml is given string (#2791)

Sometimes `Item::getContent` returns `null`, in which case `sanitizeHtml`
would pass it to `str_replace`, which would raise `E_DEPRECATED` on PHP 8.1.
---
 formats/JsonFormat.php | 2 +-
 formats/MrssFormat.php | 2 +-
 lib/FormatAbstract.php | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/formats/JsonFormat.php b/formats/JsonFormat.php
index 90bae863..1efc87fe 100644
--- a/formats/JsonFormat.php
+++ b/formats/JsonFormat.php
@@ -49,7 +49,7 @@ class JsonFormat extends FormatAbstract {
 			$entryTitle = $item->getTitle();
 			$entryUri = $item->getURI();
 			$entryTimestamp = $item->getTimestamp();
-			$entryContent = $this->sanitizeHtml($item->getContent());
+			$entryContent = $item->getContent() ? $this->sanitizeHtml($item->getContent()) : '';
 			$entryEnclosures = $item->getEnclosures();
 			$entryCategories = $item->getCategories();
 
diff --git a/formats/MrssFormat.php b/formats/MrssFormat.php
index 441d2917..386b7d37 100644
--- a/formats/MrssFormat.php
+++ b/formats/MrssFormat.php
@@ -100,7 +100,7 @@ class MrssFormat extends FormatAbstract {
 			$itemTimestamp = $item->getTimestamp();
 			$itemTitle = $item->getTitle();
 			$itemUri = $item->getURI();
-			$itemContent = $this->sanitizeHtml($item->getContent());
+			$itemContent = $item->getContent() ? $this->sanitizeHtml($item->getContent()) : '';
 			$entryID = $item->getUid();
 			$isPermaLink = 'false';
 
diff --git a/lib/FormatAbstract.php b/lib/FormatAbstract.php
index 5514b0b5..768b0157 100644
--- a/lib/FormatAbstract.php
+++ b/lib/FormatAbstract.php
@@ -130,7 +130,7 @@ abstract class FormatAbstract implements FormatInterface {
 	 * @todo Maybe switch to http://htmlpurifier.org/
 	 * @todo Maybe switch to http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/index.php
 	 */
-	protected function sanitizeHtml($html)
+	protected function sanitizeHtml(string $html): string
 	{
 		$html = str_replace('<script', '<&zwnj;script', $html); // Disable scripts, but leave them visible.
 		$html = str_replace('<iframe', '<&zwnj;iframe', $html);