cuqmbr/rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-04-23 23:16:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add check for default value of getCacheDuration

Browse Source
This commit is contained in:
logmanoriginal 2016-08-06 16:43:12 +02:00
parent 57e4d003af
commit 12191bdfff
1 changed files with 43 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
tests/BridgeImplementationTest.php
View File

@ -62,10 +62,41 @@ class BridgeImplementationTest extends PHPUnit_Framework_TestCase {
$this->assertEmpty($methods, $bridgeName . ' extends (' . $parent_names . ') and defines additional public functions : ' . $method_names . '!'); $this->assertEmpty($methods, $bridgeName . ' extends (' . $parent_names . ') and defines additional public functions : ' . $method_names . '!');
} }
// Checks if the bridge returns the default value for 'getCacheDuration()'
private function CheckBridgeGetCacheDurationDefaultValue($bridgeName){
// We only care for bridges that don't implement BridgeInterface directly
// (using one of the abstract classes)
// This is why we got the 'BridgeAbstractTest' class below!!!
if(in_array('BridgeAbstract', class_parents($bridgeName))){
// Let's check if the bridge actually implements 'getCacheDuration'
$bridgeReflector = new ReflectionClass($bridgeName);
$bridgeMethods = $bridgeReflector->GetMethods();
$bridgeHasMethod = false;
foreach($bridgeMethods as $method){
if($method->name === 'getCacheDuration' && $method->class === $bridgeReflector->name){
$bridgeHasMethod = true;
//break;
}
}
if(!$bridgeHasMethod)
return;
$bridge = new $bridgeName();
$abstract = new BridgeAbstractTest();
$this->assertNotEquals($bridge->getCacheDuration(), $abstract->getCacheDuration(), $bridgeName . ' seems to implement \'getCacheDuration\' with default values, so you might safely remove it');
}
}
public function testBridgeImplementation($bridgeName){ public function testBridgeImplementation($bridgeName){
require_once('bridges/' . $bridgeName . '.php'); require_once('bridges/' . $bridgeName . '.php');
$this->CheckBridgePublicFunctions($bridgeName); $this->CheckBridgePublicFunctions($bridgeName);
$this->CheckBridgeGetCacheDurationDefaultValue($bridgeName);
} }
public function count() public function count()
@ -110,3 +141,15 @@ class BridgeImplementationTest extends PHPUnit_Framework_TestCase {
return $result; return $result;
} }
} }
/*
This class is used for testing default values of 'getCacheDuration'!
It must not return any values, just implement all abstract functions!
*/
class BridgeAbstractTest extends BridgeAbstract{
public function loadMetadatas(){}
public function collectData(array $params){}
public function getName(){return '';}
public function getURI(){return '';}
}