cuqmbr/rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-04-05 00:59:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

[PatreonBridge] resolve null coalescing issue (#3664)

Browse Source 
* extend post presentation

* applied phpcbf

note: phpcs does not like long null coalescing chains

* resolved phpcs

* resolved github comment https://github.com/RSS-Bridge/rss-bridge/pull/3617/#issuecomment-1699568400

* .

* lint SteamAppNewsBridge
This commit is contained in:
mruac 2023-09-11 20:45:14 +09:30 committed by GitHub
parent a9cf1512e7
commit 3e1e96e477
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
bridges/PatreonBridge.php
View File

@ -132,8 +132,9 @@ class PatreonBridge extends BridgeAbstract
$audio = $this->findInclude($posts, 'media', $id)->attributes ?? null; $audio = $this->findInclude($posts, 'media', $id)->attributes ?? null;
} }
} }
$thumbnail = $post->attributes->thumbnail->large ?? $post->attributes->thumbnail->url; $thumbnail = $post->attributes->thumbnail->large ?? null;
$thumbnail = $thumbnail ?? $post->attributes->image->thumb_url; $thumbnail = $thumbnail ?? $post->attributes->thumbnail->url ?? null;
$thumbnail = $thumbnail ?? $post->attributes->image->thumb_url ?? null;
$thumbnail = $thumbnail ?? $post->attributes->image->url; $thumbnail = $thumbnail ?? $post->attributes->image->url;
$audio_filename = $audio->file_name ?? $item['title']; $audio_filename = $audio->file_name ?? $item['title'];
$download_url = $audio->download_url ?? $item['uri']; $download_url = $audio->download_url ?? $item['uri'];
@ -146,15 +147,17 @@ class PatreonBridge extends BridgeAbstract
break; break;
case 'video_embed': case 'video_embed':
$thumbnail = $post->attributes->thumbnail->large ?? $post->attributes->thumbnail->url; $thumbnail = $post->attributes->thumbnail->large ?? null;
$thumbnail = $thumbnail ?? $post->attributes->image->thumb_url; $thumbnail = $thumbnail ?? $post->attributes->thumbnail->url ?? null;
$thumbnail = $thumbnail ?? $post->attributes->image->thumb_url ?? null;
$thumbnail = $thumbnail ?? $post->attributes->image->url; $thumbnail = $thumbnail ?? $post->attributes->image->url;
$item['content'] .= "<p><a href=\"{$item['uri']}\">🎬 {$item['title']}<br><img src=\"{$thumbnail}\"></a></p>"; $item['content'] .= "<p><a href=\"{$item['uri']}\">🎬 {$item['title']}<br><img src=\"{$thumbnail}\"></a></p>";
break; break;
case 'video_external_file': case 'video_external_file':
$thumbnail = $post->attributes->thumbnail->large ?? $post->attributes->thumbnail->url; $thumbnail = $post->attributes->thumbnail->large ?? null;
$thumbnail = $thumbnail ?? $post->attributes->image->thumb_url; $thumbnail = $thumbnail ?? $post->attributes->thumbnail->url ?? null;
$thumbnail = $thumbnail ?? $post->attributes->image->thumb_url ?? null;
$thumbnail = $thumbnail ?? $post->attributes->image->url; $thumbnail = $thumbnail ?? $post->attributes->image->url;
$item['content'] .= "<p><a href=\"{$item['uri']}\">🎬 {$item['title']}<br><img src=\"{$thumbnail}\"></a></p>"; $item['content'] .= "<p><a href=\"{$item['uri']}\">🎬 {$item['title']}<br><img src=\"{$thumbnail}\"></a></p>";
break; break;

3
bridges/SteamAppNewsBridge.php
View File

@ -41,8 +41,7 @@ class SteamAppNewsBridge extends BridgeAbstract
$apiTarget = 'https://api.steampowered.com/ISteamNews/GetNewsForApp/v2/'; $apiTarget = 'https://api.steampowered.com/ISteamNews/GetNewsForApp/v2/';
// Example with params: https://api.steampowered.com/ISteamNews/GetNewsForApp/v2/?appid=730&maxlength=0&count=20 // Example with params: https://api.steampowered.com/ISteamNews/GetNewsForApp/v2/?appid=730&maxlength=0&count=20
// More info at dev docs https://partner.steamgames.com/doc/webapi/ISteamNews // More info at dev docs https://partner.steamgames.com/doc/webapi/ISteamNews
$url = $url = $apiTarget
$apiTarget
. '?appid=' . $this->getInput('appid') . '?appid=' . $this->getInput('appid')
. '&maxlength=' . $this->getInput('maxlength') . '&maxlength=' . $this->getInput('maxlength')
. '&count=' . $this->getInput('count') . '&count=' . $this->getInput('count')