From 42379071e9cfff44ae2ed771f22299a233eb4872 Mon Sep 17 00:00:00 2001
From: Christian Schabesberger <chris.schabesberger@mailbox.org>
Date: Sat, 6 Nov 2021 19:28:12 +0100
Subject: [PATCH] [NordbayernBridge] Fix banner URL (#2326)

* make banner images show for nordbayern again
* make author portrait not apear as article banner for nordbayern
---
 bridges/NordbayernBridge.php | 32 +++++++++++++++++++++++++++-----
 1 file changed, 27 insertions(+), 5 deletions(-)

diff --git a/bridges/NordbayernBridge.php b/bridges/NordbayernBridge.php
index 52b1f3ec..ba1671b2 100644
--- a/bridges/NordbayernBridge.php
+++ b/bridges/NordbayernBridge.php
@@ -63,6 +63,19 @@ class NordbayernBridge extends BridgeAbstract {
 		return $content;
 	}
 
+	private function getValidImages($pictures) {
+		$images = array();
+		if(!empty($pictures)) {
+			for($i = 0; $i < count($pictures); $i++) {
+				$imgUrl = $pictures[$i]->find('img', 0)->src;
+				if(strcmp($imgUrl, 'https://www.nordbayern.de/img/nb/logo-vnp.png') !== 0) {
+					array_push($images, $imgUrl);
+				}
+			}
+		}
+		return $images;
+	}
+
 	private function handleArticle($link) {
 		$item = array();
 		$article = getSimpleHTMLDOM($link);
@@ -78,8 +91,18 @@ class NordbayernBridge extends BridgeAbstract {
 
 		//first get images from content
 		$pictures = $article->find('picture');
-		if(!empty($pictures)) {
-			$bannerUrl = $pictures[0]->find('img', 0)->src;
+		$images = self::getValidImages($pictures);
+		if(!empty($images)) {
+			// If there is an author info block
+			// the first immage will be the portrait of the author
+			// and not the article banner. The banner in this
+			// case will be the second image.
+			if ($article->find('div[class=authorinfo]', 0) == null) {
+				$bannerUrl = $images[0];
+			} else {
+				$bannerUrl = $images[1];
+			}
+
 			$item['content'] .= '<img src="' . $bannerUrl . '">';
 		}
 
@@ -93,9 +116,8 @@ class NordbayernBridge extends BridgeAbstract {
 			$item['content'] .= self::getUseFullContent($content);
 		}
 
-		for($i = 1; $i < count($pictures); $i++) {
-			$imgUrl = $pictures[$i]->find('img', 0)->src;
-			$item['content'] .= '<img src="' . $imgUrl . '">';
+		for($i = 0; $i < count($images); $i++) {
+			$item['content'] .= '<img src="' . $images[$i] . '">';
 		}
 
 		// exclude police reports if descired