From 8aa091beda927b00375c66f882700de600198546 Mon Sep 17 00:00:00 2001 From: Yaman Qalieh Date: Fri, 1 Apr 2022 10:38:07 -0400 Subject: [PATCH] [GithubIssueBridge] Fix notice with reviews (#2589) Some timeline items, like review threads and the first comment on PRs, have no header, so this handles the first comment and adds a generic title if that doesn't work. --- bridges/GithubIssueBridge.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/bridges/GithubIssueBridge.php b/bridges/GithubIssueBridge.php index ea78a47d..5834f72a 100644 --- a/bridges/GithubIssueBridge.php +++ b/bridges/GithubIssueBridge.php @@ -128,9 +128,8 @@ class GithubIssueBridge extends BridgeAbstract { $author = $comment->find('.author', 0)->plaintext; - $title .= ' / ' . trim( - $comment->find('.timeline-comment-header-text', 0)->plaintext - ); + $header = $comment->find('.timeline-comment-header > h3', 0); + $title .= ' / ' . ($header ? $header->plaintext : 'Activity'); $time = $comment->find('relative-time', 0); if ($time === null) {