From 8e2b65556f0a5eb063761d594f2fd6ac1b10d154 Mon Sep 17 00:00:00 2001
From: Jakub Valenta <205991+jakubvalenta@users.noreply.github.com>
Date: Thu, 24 Mar 2022 20:29:16 +0000
Subject: [PATCH] [Config] Don't check PATH_CACHE for memcached (#1489)

---
 .gitignore             | 1 +
 caches/FileCache.php   | 9 +++++++++
 caches/SQLiteCache.php | 7 +++++++
 lib/Configuration.php  | 4 ----
 4 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/.gitignore b/.gitignore
index 680260c7..84fae867 100644
--- a/.gitignore
+++ b/.gitignore
@@ -213,6 +213,7 @@ pip-log.txt
 
 # Unit test / coverage reports
 .coverage
+.phpunit.result.cache
 .tox
 
 #Translations
diff --git a/caches/FileCache.php b/caches/FileCache.php
index 166ecdb5..1b8ae6cd 100644
--- a/caches/FileCache.php
+++ b/caches/FileCache.php
@@ -6,6 +6,15 @@ class FileCache implements CacheInterface {
 	protected $path;
 	protected $key;
 
+	public function __construct() {
+		if (!is_writable(PATH_CACHE)) {
+			returnServerError(
+				'RSS-Bridge does not have write permissions for '
+				. PATH_CACHE . '!'
+			);
+		}
+	}
+
 	public function loadData(){
 		if(file_exists($this->getCacheFile())) {
 			return unserialize(file_get_contents($this->getCacheFile()));
diff --git a/caches/SQLiteCache.php b/caches/SQLiteCache.php
index 394e25fa..5ec69417 100644
--- a/caches/SQLiteCache.php
+++ b/caches/SQLiteCache.php
@@ -13,6 +13,13 @@ class SQLiteCache implements CacheInterface {
 			die('"sqlite3" extension not loaded. Please check "php.ini"');
 		}
 
+		if (!is_writable(PATH_CACHE)) {
+			returnServerError(
+				'RSS-Bridge does not have write permissions for '
+				. PATH_CACHE . '!'
+			);
+		}
+
 		$file = Configuration::getConfig(get_called_class(), 'file');
 		if (empty($file)) {
 			die('Configuration for ' . get_called_class() . ' missing. Please check your ' . FILE_CONFIG);
diff --git a/lib/Configuration.php b/lib/Configuration.php
index f0022810..b3592371 100644
--- a/lib/Configuration.php
+++ b/lib/Configuration.php
@@ -102,10 +102,6 @@ final class Configuration {
 		if(!extension_loaded('json'))
 			self::reportError('"json" extension not loaded. Please check "php.ini"');
 
-		// Check cache folder permissions (write permissions required)
-		if(!is_writable(PATH_CACHE))
-			self::reportError('RSS-Bridge does not have write permissions for ' . PATH_CACHE . '!');
-
 	}
 
 	/**