cuqmbr/rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-04-05 17:19:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Twitter): properly find time line entries when ordering is inconsistent (#3461)

Browse Source
This commit is contained in:
Dag 2023-06-27 16:11:41 +02:00 committed by GitHub
parent bd6f56383c
commit 8eabdbe5f8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/TwitterClient.php
View File

@ -48,17 +48,29 @@ class TwitterClient
if ($result->__typename === 'UserUnavailable') { if ($result->__typename === 'UserUnavailable') {
throw new \Exception('UserUnavailable'); throw new \Exception('UserUnavailable');
} }
$instructionTypes = ['TimelineAddEntries', 'TimelineClearCache']; $instructionTypes = [
'TimelineAddEntries',
'TimelineClearCache',
'TimelinePinEntry', // unclear purpose, maybe pinned tweet?
];
$instructions = $result->timeline_v2->timeline->instructions; $instructions = $result->timeline_v2->timeline->instructions;
if (!isset($instructions[1])) { if (!isset($instructions[1])) {
throw new \Exception('The account exists but has not tweeted yet?'); throw new \Exception('The account exists but has not tweeted yet?');
} }
$instruction = $instructions[1];
if ($instruction->type !== 'TimelineAddEntries') { $entries = null;
throw new \Exception(sprintf('Unexpected instruction type: %s', $instruction->type)); foreach ($instructions as $instruction) {
if ($instruction->type === 'TimelineAddEntries') {
$entries = $instruction->entries;
break;
}
} }
if (!$entries) {
throw new \Exception(sprintf('Unable to find time line tweets in: %s', implode(',', array_column($instructions, 'type'))));
}
$tweets = []; $tweets = [];
foreach ($instruction->entries as $entry) { foreach ($entries as $entry) {
if ($entry->content->entryType !== 'TimelineTimelineItem') { if ($entry->content->entryType !== 'TimelineTimelineItem') {
continue; continue;
} }