mirror of
https://github.com/RSS-Bridge/rss-bridge.git
synced 2025-04-23 23:16:53 +00:00
Add new test for bridge implementation
This test currently checks all bridges for additional public functions that should actually be in private scope.
This commit is contained in:
parent
723b1e7f91
commit
ed0ec0e70d
101
tests/BridgeImplementationTest.php
Normal file
101
tests/BridgeImplementationTest.php
Normal file
@ -0,0 +1,101 @@
|
|||||||
|
<?php
|
||||||
|
|
||||||
|
require_once('lib/Bridge.php');
|
||||||
|
|
||||||
|
/*
|
||||||
|
This class will check all bridges for proper implementation
|
||||||
|
*/
|
||||||
|
class BridgeImplementationTest extends PHPUnit_Framework_TestCase {
|
||||||
|
|
||||||
|
// Returns an array of all bridge files (file names without file type)
|
||||||
|
private function ListBridges(){
|
||||||
|
$listBridge = array();
|
||||||
|
$dirFiles = scandir('bridges/');
|
||||||
|
|
||||||
|
if( $dirFiles !== false ){
|
||||||
|
|
||||||
|
foreach( $dirFiles as $fileName ) {
|
||||||
|
if( preg_match('@([^.]+)\.php$@U', $fileName, $out) ){
|
||||||
|
$listBridge[] = $out[1];
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return $listBridge;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Checks if the bridge implements additional public functions (should not be!)
|
||||||
|
private function CheckBridgePublicFunctions($bridgeName){
|
||||||
|
require_once('bridges/' . $bridgeName . '.php');
|
||||||
|
|
||||||
|
$parent_methods = array();
|
||||||
|
|
||||||
|
if(in_array('BridgeInterface', class_parents($bridgeName)))
|
||||||
|
$parent_methods = array_merge($parent_methods, get_class_methods('BridgeInterface'));
|
||||||
|
|
||||||
|
if(in_array('BridgeAbstract', class_parents($bridgeName)))
|
||||||
|
$parent_methods = array_merge($parent_methods, get_class_methods('BridgeAbstract'));
|
||||||
|
|
||||||
|
if(in_array('HttpCachingBridgeAbstract', class_parents($bridgeName)))
|
||||||
|
$parent_methods = array_merge($parent_methods, get_class_methods('HttpCachingBridgeAbstract'));
|
||||||
|
|
||||||
|
// Receive all non abstract methods
|
||||||
|
$methods = array_diff(get_class_methods($bridgeName), $parent_methods);
|
||||||
|
|
||||||
|
$method_names = '';
|
||||||
|
foreach($methods as $method){
|
||||||
|
if($method_names === '')
|
||||||
|
$method_names .= $method;
|
||||||
|
else
|
||||||
|
$method_names .= ', ' . $method;
|
||||||
|
}
|
||||||
|
|
||||||
|
// There should generally be no additional (public) function
|
||||||
|
$this->assertEmpty($methods, $bridgeName . " defines additional public functions!\n" . $method_names);
|
||||||
|
}
|
||||||
|
|
||||||
|
public function testBridgeImplementation($bridge){
|
||||||
|
$this->CheckBridgePublicFunctions($bridge);
|
||||||
|
}
|
||||||
|
|
||||||
|
public function count()
|
||||||
|
{
|
||||||
|
return count($this->ListBridges());
|
||||||
|
}
|
||||||
|
|
||||||
|
public function run(PHPUnit_Framework_TestResult $result = NULL)
|
||||||
|
{
|
||||||
|
if ($result === NULL) {
|
||||||
|
$result = new PHPUnit_Framework_TestResult;
|
||||||
|
}
|
||||||
|
|
||||||
|
foreach ($this->ListBridges() as $bridge) {
|
||||||
|
$result->startTest($this);
|
||||||
|
PHP_Timer::start();
|
||||||
|
$stopTime = NULL;
|
||||||
|
|
||||||
|
//list($expected, $actual) = explode(';', $bridge);
|
||||||
|
|
||||||
|
try {
|
||||||
|
$this->testBridgeImplementation($bridge);
|
||||||
|
}
|
||||||
|
|
||||||
|
catch (PHPUnit_Framework_AssertionFailedError $e) {
|
||||||
|
$stopTime = PHP_Timer::stop();
|
||||||
|
$result->addFailure($this, $e, $stopTime);
|
||||||
|
}
|
||||||
|
|
||||||
|
catch (Exception $e) {
|
||||||
|
$stopTime = PHP_Timer::stop();
|
||||||
|
$result->addError($this, $e, $stopTime);
|
||||||
|
}
|
||||||
|
|
||||||
|
if ($stopTime === NULL) {
|
||||||
|
$stopTime = PHP_Timer::stop();
|
||||||
|
}
|
||||||
|
|
||||||
|
$result->endTest($this, $stopTime);
|
||||||
|
}
|
||||||
|
|
||||||
|
return $result;
|
||||||
|
}
|
||||||
|
}
|
Loading…
Reference in New Issue
Block a user