From c3a943f02e4a1fdd988814a399d6b267b6e81c66 Mon Sep 17 00:00:00 2001 From: cuqmbr Date: Sat, 30 Jul 2022 21:34:52 +0300 Subject: [PATCH] refactor: add error handling in AuthenticationResponse --- Server/Controllers/AuthenticationController.cs | 4 ++-- SharedModels/Responses/AuthenticationResponse.cs | 3 +++ SharedModels/SharedModels.csproj | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Server/Controllers/AuthenticationController.cs b/Server/Controllers/AuthenticationController.cs index 9e676af..dbafe9c 100644 --- a/Server/Controllers/AuthenticationController.cs +++ b/Server/Controllers/AuthenticationController.cs @@ -24,7 +24,7 @@ public class AuthenticationController : ControllerBase if (!success) { - return BadRequest(content); + return BadRequest(new AuthenticationResponse {IsError = true, ErrorMessage = content} ); } return await Login(request); @@ -38,7 +38,7 @@ public class AuthenticationController : ControllerBase if (!success) { - return BadRequest("Username or password is incorrect."); + return BadRequest(new AuthenticationResponse {IsError = true, ErrorMessage = "Username or password is incorrect."}); } return Ok(new AuthenticationResponse { Token = content } ); diff --git a/SharedModels/Responses/AuthenticationResponse.cs b/SharedModels/Responses/AuthenticationResponse.cs index 6075a3e..26ae9ca 100644 --- a/SharedModels/Responses/AuthenticationResponse.cs +++ b/SharedModels/Responses/AuthenticationResponse.cs @@ -2,5 +2,8 @@ namespace DatabaseModels.Responses; public class AuthenticationResponse { + public bool IsError { get; set; } + public string ErrorMessage { get; set; } = null!; + public string Token { get; set; } = null!; } \ No newline at end of file diff --git a/SharedModels/SharedModels.csproj b/SharedModels/SharedModels.csproj index c58f151..1842c76 100644 --- a/SharedModels/SharedModels.csproj +++ b/SharedModels/SharedModels.csproj @@ -8,7 +8,7 @@ - +