cuqmbr/single_php_filehost
1
0
Fork 0
mirror of https://github.com/Rouji/single_php_filehost.git synced 2025-04-04 16:39:34 +00:00
Code

clean up strings

Browse Source 
use string interpolation where it makes sense
use '' for non-interpolated ones
use print instead of printf where it makes sense
This commit is contained in:
Rouji 2021-08-29 22:53:31 +02:00
parent 503f5e7272
commit 7d5c9719c2
1 changed files with 47 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

95
index.php
View File

@ -8,14 +8,14 @@ class CONFIG
const UPLOAD_TIMEOUT=5*60; //max. time an upload can take before it times out const UPLOAD_TIMEOUT=5*60; //max. time an upload can take before it times out
const ID_LENGTH=3; //length of the random file ID const ID_LENGTH=3; //length of the random file ID
const STORE_PATH="files/"; //directory to store uploaded files in const STORE_PATH='files/'; //directory to store uploaded files in
const LOG_PATH=null; //path to log uploads + resulting links to const LOG_PATH=null; //path to log uploads + resulting links to
const DOWNLOAD_PATH="%s"; //the path part of the download url. %s = placeholder for filename const DOWNLOAD_PATH='%s'; //the path part of the download url. %s = placeholder for filename
const MAX_EXT_LEN=7; //max. length for file extensions const MAX_EXT_LEN=7; //max. length for file extensions
const EXTERNAL_HOOK=null; const EXTERNAL_HOOK=null;
const AUTO_FILE_EXT=false; const AUTO_FILE_EXT=false;
const ADMIN_EMAIL="admin@example.com"; //address for inquiries const ADMIN_EMAIL='admin@example.com'; //address for inquiries
public static function SITE_URL() public static function SITE_URL()
{ {
@ -53,14 +53,13 @@ function check_config()
{ {
$ini_val = intval(ini_get($ini_name)); $ini_val = intval(ini_get($ini_name));
if ($ini_val < $var_val) if ($ini_val < $var_val)
printf("<pre>Warning: php.ini: %s (%s) set lower than %s (%s)\n</pre>", print("<pre>Warning: php.ini: $ini_name ($ini_val) set lower than $var_name ($var_val)\n</pre>");
$ini_name, $ini_val, $var_name, $var_val);
}; };
$warn_config_value('upload_max_filesize', "MAX_FILESIZE", CONFIG::MAX_FILESIZE); $warn_config_value('upload_max_filesize', 'MAX_FILESIZE', CONFIG::MAX_FILESIZE);
$warn_config_value('post_max_size', "MAX_FILESIZE", CONFIG::MAX_FILESIZE); $warn_config_value('post_max_size', 'MAX_FILESIZE', CONFIG::MAX_FILESIZE);
$warn_config_value('max_input_time', "UPLOAD_TIMEOUT", CONFIG::UPLOAD_TIMEOUT); $warn_config_value('max_input_time', 'UPLOAD_TIMEOUT', CONFIG::UPLOAD_TIMEOUT);
$warn_config_value('max_execution_time', "UPLOAD_TIMEOUT", CONFIG::UPLOAD_TIMEOUT); $warn_config_value('max_execution_time', 'UPLOAD_TIMEOUT', CONFIG::UPLOAD_TIMEOUT);
} }
//extract extension from a path (does not include the dot) //extract extension from a path (does not include the dot)
@ -81,21 +80,21 @@ function ext_by_finfo($path)
$finfo = finfo_open(FILEINFO_EXTENSION); $finfo = finfo_open(FILEINFO_EXTENSION);
$finfo_ext = finfo_file($finfo, $path); $finfo_ext = finfo_file($finfo, $path);
finfo_close($finfo); finfo_close($finfo);
if ($finfo_ext != "???") if ($finfo_ext != '???')
{ {
return explode("/", $finfo_ext, 2)[0]; return explode('/', $finfo_ext, 2)[0];
} }
else else
{ {
$finfo = finfo_open(); $finfo = finfo_open();
$finfo_info = finfo_file($finfo, $path); $finfo_info = finfo_file($finfo, $path);
finfo_close($finfo); finfo_close($finfo);
if (strstr($finfo_info, "text") !== false) if (strstr($finfo_info, 'text') !== false)
{ {
return "txt"; return 'txt';
} }
} }
return ""; return '';
} }
// store an uploaded file, given its name and temporary path (e.g. values straight out of $_FILES) // store an uploaded file, given its name and temporary path (e.g. values straight out of $_FILES)
@ -116,14 +115,14 @@ function store_file($name, $tmpfile, $formatted = false)
$size = filesize($tmpfile); $size = filesize($tmpfile);
if ($size > CONFIG::MAX_FILESIZE * 1024 * 1024) if ($size > CONFIG::MAX_FILESIZE * 1024 * 1024)
{ {
header("HTTP/1.0 413 Payload Too Large"); header('HTTP/1.0 413 Payload Too Large');
printf("Error 413: Max File Size (%d MiB) Exceeded\n", CONFIG::MAX_FILESIZE); print("Error 413: Max File Size ({CONFIG::MAX_FILESIZE} MiB) Exceeded\n");
return; return;
} }
if ($size == 0) if ($size == 0)
{ {
header("HTTP/1.0 400 Bad Request"); header('HTTP/1.0 400 Bad Request');
print("Error 400: Uploaded file is empty\n"); print('Error 400: Uploaded file is empty\n');
return; return;
} }
@ -151,22 +150,22 @@ function store_file($name, $tmpfile, $formatted = false)
if (!$res) if (!$res)
{ {
//TODO: proper error handling? //TODO: proper error handling?
header("HTTP/1.0 520 Unknown Error"); header('HTTP/1.0 520 Unknown Error');
return; return;
} }
if (CONFIG::EXTERNAL_HOOK !== null) if (CONFIG::EXTERNAL_HOOK !== null)
{ {
putenv("REMOTE_ADDR=".$_SERVER['REMOTE_ADDR']); putenv('REMOTE_ADDR='.$_SERVER['REMOTE_ADDR']);
putenv("ORIGINAL_NAME=".$name); putenv('ORIGINAL_NAME='.$name);
putenv("STORED_FILE=".$target_file); putenv('STORED_FILE='.$target_file);
$ret = -1; $ret = -1;
$out = exec(CONFIG::EXTERNAL_HOOK, $_ = null, $ret); $out = exec(CONFIG::EXTERNAL_HOOK, $_ = null, $ret);
if ($out !== false && $ret !== 0) if ($out !== false && $ret !== 0)
{ {
unlink($target_file); unlink($target_file);
header("HTTP/1.0 400 Bad Request"); header('HTTP/1.0 400 Bad Request');
print("Error: ".$out."\n"); print("Error: $out\n");
return; return;
} }
} }
@ -176,11 +175,11 @@ function store_file($name, $tmpfile, $formatted = false)
if ($formatted) if ($formatted)
{ {
printf('<pre>Access your file here: <a href="%s">%s</a></pre>', $url, $url); print("<pre>Access your file here: <a href=\"$url\">$url</a></pre>");
} }
else else
{ {
printf($url."\n"); print("$url\n");
} }
// log uploader's IP, original filename, etc. // log uploader's IP, original filename, etc.
@ -188,13 +187,13 @@ function store_file($name, $tmpfile, $formatted = false)
{ {
file_put_contents( file_put_contents(
CONFIG::LOG_PATH, CONFIG::LOG_PATH,
implode("\t", array( implode('\t', array(
date('c'), date('c'),
$_SERVER['REMOTE_ADDR'], $_SERVER['REMOTE_ADDR'],
filesize($tmpfile), filesize($tmpfile),
escapeshellarg($name), escapeshellarg($name),
$basename $basename
)) . "\n", )) . '\n',
FILE_APPEND FILE_APPEND
); );
} }
@ -237,20 +236,20 @@ function purge_files()
{ {
unlink($file); unlink($file);
printf("deleted \"%s\", %d MiB, %d days old\n", $file, $file_size, $file_age); print("deleted $file, $file_size MiB, $file_age days old\n");
$num_del += 1; $num_del += 1;
$total_size += $file_size; $total_size += $file_size;
} }
} }
printf("Deleted %d files totalling %d MiB\n", $num_del, $total_size); print("Deleted $num_del files totalling $total_size MiB\n");
} }
// send a ShareX custom uploader config as .json // send a ShareX custom uploader config as .json
function send_sharex_config() function send_sharex_config()
{ {
$name = $_SERVER["SERVER_NAME"]; $name = $_SERVER['SERVER_NAME'];
$site_url = CONFIG::SITE_URL(); $site_url = CONFIG::SITE_URL();
$filename = $name.".sxcu"; $filename = $name.'.sxcu';
$content = <<<EOT $content = <<<EOT
{ {
"Name": "$name", "Name": "$name",
@ -261,18 +260,18 @@ function send_sharex_config()
"ResponseType": "Text" "ResponseType": "Text"
} }
EOT; EOT;
header("Content-type: application/octet-stream"); header('Content-type: application/octet-stream');
header('Content-Disposition: attachment; filename="'.$filename.'"'); header("Content-Disposition: attachment; filename=\"$filename\"");
header("Content-Length: ".strlen($content)); header('Content-Length: '.strlen($content));
print($content); print($content);
} }
// send a Hupl uploader config as .hupl (which is just JSON) // send a Hupl uploader config as .hupl (which is just JSON)
function send_hupl_config() function send_hupl_config()
{ {
$name = $_SERVER["SERVER_NAME"]; $name = $_SERVER['SERVER_NAME'];
$site_url = CONFIG::SITE_URL(); $site_url = CONFIG::SITE_URL();
$filename = $name.".hupl"; $filename = $name.'.hupl';
$content = <<<EOT $content = <<<EOT
{ {
"name": "$name", "name": "$name",
@ -281,9 +280,9 @@ function send_hupl_config()
"fileParam": "file" "fileParam": "file"
} }
EOT; EOT;
header("Content-type: application/octet-stream"); header('Content-type: application/octet-stream');
header('Content-Disposition: attachment; filename="'.$filename.'"'); header("Content-Disposition: attachment; filename=\"$filename.\"");
header("Content-Length: ".strlen($content)); header('Content-Length: '.strlen($content));
print($content); print($content);
} }
@ -292,8 +291,8 @@ EOT;
function print_index() function print_index()
{ {
$site_url = CONFIG::SITE_URL(); $site_url = CONFIG::SITE_URL();
$sharex_url = $site_url."?sharex"; $sharex_url = $site_url.'?sharex';
$hupl_url = $site_url."?hupl"; $hupl_url = $site_url.'?hupl';
$decay = CONFIG::DECAY_EXP; $decay = CONFIG::DECAY_EXP;
$min_age = CONFIG::MIN_FILEAGE; $min_age = CONFIG::MIN_FILEAGE;
$max_size = CONFIG::MAX_FILESIZE; $max_size = CONFIG::MAX_FILESIZE;
@ -364,14 +363,14 @@ EOT;
// decide what to do, based on POST parameters etc. // decide what to do, based on POST parameters etc.
if (isset($_FILES["file"]["name"]) && if (isset($_FILES['file']['name']) &&
isset($_FILES["file"]["tmp_name"]) && isset($_FILES['file']['tmp_name']) &&
is_uploaded_file($_FILES["file"]["tmp_name"])) is_uploaded_file($_FILES['file']['tmp_name']))
{ {
//file was uploaded, store it //file was uploaded, store it
$formatted = isset($_GET["formatted"]) || isset($_POST["formatted"]); $formatted = isset($_GET['formatted']) || isset($_POST['formatted']);
store_file($_FILES["file"]["name"], store_file($_FILES['file']['name'],
$_FILES["file"]["tmp_name"], $_FILES['file']['tmp_name'],
$formatted); $formatted);
} }
else if (isset($_GET['sharex'])) else if (isset($_GET['sharex']))