mirrors/terraform-provider-proxmox
0
0
Fork 0
mirror of https://github.com/bpg/terraform-provider-proxmox.git synced 2025-07-01 19:12:59 +00:00
Code

feat(provider): better error logging when provider can't generate a VM/Container ID (#1645)

Browse Source 
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
This commit is contained in:
Pavel Boldyrev 2024-11-19 21:07:17 -05:00 committed by GitHub
parent 8c17e81476
commit 071cad4df2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
proxmox/cluster/id_generator.go
View File

@ -93,6 +93,8 @@ func (g IDGenerator) NextID(ctx context.Context) (int, error) {
var newID *int var newID *int
var errs []error
id, err := retry.DoWithData(func() (*int, error) { id, err := retry.DoWithData(func() (*int, error) {
if g.config.RandomIDs { if g.config.RandomIDs {
//nolint:gosec //nolint:gosec
@ -109,6 +111,8 @@ func (g IDGenerator) NextID(ctx context.Context) (int, error) {
retry.OnRetry(func(_ uint, err error) { retry.OnRetry(func(_ uint, err error) {
if strings.Contains(err.Error(), "already exists") && newID != nil { if strings.Contains(err.Error(), "already exists") && newID != nil {
newID = ptr.Ptr(*newID + 1) newID = ptr.Ptr(*newID + 1)
} else {
errs = append(errs, err)
} }
}), }),
retry.Context(ctx), retry.Context(ctx),
@ -117,7 +121,8 @@ func (g IDGenerator) NextID(ctx context.Context) (int, error) {
retry.Delay(200*time.Millisecond), retry.Delay(200*time.Millisecond),
) )
if err != nil { if err != nil {
return -1, fmt.Errorf("unable to retrieve the next available VM identifier: %w", err) errs = append(errs, err)
return -1, fmt.Errorf("unable to retrieve the next available VM identifier: %w", errors.Join(errs...))
} }
if !g.config.RandomIDs { if !g.config.RandomIDs {