mirrors/terraform-provider-proxmox
0
0
Fork 0
mirror of https://github.com/bpg/terraform-provider-proxmox.git synced 2025-06-29 18:21:10 +00:00
Code

fix(vm): retry start if it fails with a transient error (#1685)

Browse Source 
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
This commit is contained in:
Pavel Boldyrev 2024-12-17 14:31:46 -05:00 committed by GitHub
parent bf9e2436d4
commit 9d2118d762
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
proxmox/nodes/vms/vms.go
View File

@ -423,7 +423,24 @@ func (c *Client) StartVMAsync(ctx context.Context, timeoutSec int) (*string, err
}
resBody := &StartResponseBody{}
err := c.DoRequest(ctx, http.MethodPost, c.ExpandPath("status/start"), reqBody, resBody)
// PVE may return a 500 error "got no worker upid - start worker failed", so we retry few times.
err := retry.Do(
func() error {
err := c.DoRequest(ctx, http.MethodPost, c.ExpandPath("status/start"), reqBody, resBody)
if err != nil && strings.Contains(err.Error(), "already running") {
return nil
}
return err
},
retry.Context(ctx),
retry.Attempts(3),
retry.Delay(1*time.Second),
retry.LastErrorOnly(true),
retry.RetryIf(func(err error) bool {
return strings.Contains(err.Error(), "got no worker upid")
}),
)
if err != nil {
return nil, fmt.Errorf("error starting VM: %w", err)
}