From db7afe2e4a93ae3f97c0533dba0adaf82123c49f Mon Sep 17 00:00:00 2001 From: Pavel Boldyrev <627562+bpg@users.noreply.github.com> Date: Sun, 2 Apr 2023 15:35:10 -0400 Subject: [PATCH] chore: add missing docs (#283) * added documentation for #282 * add contributor's note to the PR template --- .github/PULL_REQUEST_TEMPLATE.md | 7 +++++++ docs/resources/virtual_environment_vm.md | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b722c007..83db7475 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,3 +1,10 @@ +### Contributor's Note +Please mark the following items with an [x] if they apply to your PR. +Leave the [ ] if they are not applicable, or if you have not completed the item. +- [ ] I have added / updated documentation in `/docs` for any user-facing features or additions. +- [ ] I have added / updated templates in `/examples` for any new or updated resources / data sources. + - [ ] I have ran `make examples` to verify that the change works as expected. + ### Community Note diff --git a/docs/resources/virtual_environment_vm.md b/docs/resources/virtual_environment_vm.md index 5c79d43e..9dc5a9d8 100644 --- a/docs/resources/virtual_environment_vm.md +++ b/docs/resources/virtual_environment_vm.md @@ -361,6 +361,13 @@ output "ubuntu_vm_public_key" { - `device` - (Optional) The device (defaults to `socket`). - `/dev/*` - A host serial device. - `socket` - A unix socket. +- `scsi_hardware` - (Optional) The SCSI hardware type (defaults to `virtio-scsi-pci`). + - `lsi` - LSI Logic SAS1068E. + - `lsi53c810` - LSI Logic 53C810. + - `virtio-scsi-pci` - VirtIO SCSI. + - `virtio-scsi-single` - VirtIO SCSI (single queue). + - `megasas` - LSI Logic MegaRAID SAS. + - `pvscsi` - VMware Paravirtual SCSI. - `started` - (Optional) Whether to start the virtual machine (defaults to `true`). - `tablet_device` - (Optional) Whether to enable the USB tablet device (defaults