mirrors/terraform-provider-proxmox
0
0
Fork 0
mirror of https://github.com/bpg/terraform-provider-proxmox.git synced 2025-06-30 18:42:58 +00:00
Code

fix(storage): ignore os.ErrClosed from deferred fileReader.Close() in storage.APIUpload (#1468)

Browse Source 
fix(provider): ignore `ErrClosed` for fileReader

Signed-off-by: Keith King <KingKeithC@gmail.com>
This commit is contained in:
Keith 2024-08-06 20:36:24 -06:00 committed by GitHub
parent f7c3560260
commit e8bd1fcda7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
proxmox/nodes/storage/upload.go
View File

@ -2,6 +2,7 @@ package storage
import (
"context"
"errors"
"fmt"
"io"
"mime/multipart"
@ -112,6 +113,11 @@ func (c *Client) APIUpload(
defer func(fileReader *os.File) {
e := fileReader.Close()
if e != nil {
if errors.Is(e, os.ErrClosed) {
// We can ignore the error in the case that the file was already closed.
return
}
tflog.Error(ctx, "failed to close file reader", map[string]interface{}{
"error": e,
})