From f4ee6291ccd42ef6c6c7d0e8d6780f68a46ac218 Mon Sep 17 00:00:00 2001
From: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Date: Wed, 11 Sep 2024 18:20:29 -0400
Subject: [PATCH] feat(vm): remove deprecated `vga.enabled` (#1533)

Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
---
 fwprovider/network/resource_linux_vlan_test.go | 2 +-
 proxmoxtf/resource/vm/vm.go                    | 8 --------
 proxmoxtf/resource/vm/vm_test.go               | 6 ++----
 3 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/fwprovider/network/resource_linux_vlan_test.go b/fwprovider/network/resource_linux_vlan_test.go
index adfd2db7..c31e4411 100644
--- a/fwprovider/network/resource_linux_vlan_test.go
+++ b/fwprovider/network/resource_linux_vlan_test.go
@@ -26,7 +26,7 @@ const (
 func TestAccResourceLinuxVLAN(t *testing.T) {
 	te := test.InitEnvironment(t)
 
-	iface := "ens18"
+	iface := "enp1s0"
 	vlan1 := gofakeit.Number(10, 4094)
 	customName := fmt.Sprintf("iface_%s", gofakeit.Word())
 	vlan2 := gofakeit.Number(10, 4094)
diff --git a/proxmoxtf/resource/vm/vm.go b/proxmoxtf/resource/vm/vm.go
index 862eaa1b..03fab7b8 100644
--- a/proxmoxtf/resource/vm/vm.go
+++ b/proxmoxtf/resource/vm/vm.go
@@ -271,7 +271,6 @@ const (
 	mkHostUSBDeviceUSB3    = "usb3"
 	mkVGA                  = "vga"
 	mkVGAClipboard         = "clipboard"
-	mkVGAEnabled           = "enabled"
 	mkVGAMemory            = "memory"
 	mkVGAType              = "type"
 	mkVMID                 = "vm_id"
@@ -1409,13 +1408,6 @@ func VM() *schema.Resource {
 							"vnc",
 						}, true)),
 					},
-					mkVGAEnabled: {
-						Type: schema.TypeBool,
-						Deprecated: "The `enabled` attribute is deprecated and will be removed in a future release. " +
-							"Use type `none` instead.",
-						Description: "Whether to enable the VGA device",
-						Optional:    true,
-					},
 					mkVGAMemory: {
 						Type:             schema.TypeInt,
 						Description:      "The VGA memory in megabytes (4-512 MB)",
diff --git a/proxmoxtf/resource/vm/vm_test.go b/proxmoxtf/resource/vm/vm_test.go
index 43348acb..7c79e4d9 100644
--- a/proxmoxtf/resource/vm/vm_test.go
+++ b/proxmoxtf/resource/vm/vm_test.go
@@ -387,15 +387,13 @@ func TestVMSchema(t *testing.T) {
 	vgaSchema := test.AssertNestedSchemaExistence(t, s, mkVGA)
 
 	test.AssertOptionalArguments(t, vgaSchema, []string{
-		mkVGAEnabled,
 		mkVGAMemory,
 		mkVGAType,
 	})
 
 	test.AssertValueTypes(t, vgaSchema, map[string]schema.ValueType{
-		mkVGAEnabled: schema.TypeBool,
-		mkVGAMemory:  schema.TypeInt,
-		mkVGAType:    schema.TypeString,
+		mkVGAMemory: schema.TypeInt,
+		mkVGAType:   schema.TypeString,
 	})
 }