0
0
mirror of https://github.com/bpg/terraform-provider-proxmox.git synced 2025-07-04 21:14:05 +00:00
Terraform / OpenTofu Provider for Proxmox VE
Go to file
Emmanuel Benoît 03c9b36b86
feat(ha): add support for Proxmox High Availability objects (#498)
* chore: fix a pair of typos in comments

* feat(api): list High Availability groups

  * New clients created for HA and HA groups (via
    `Cluster().HA().Groups()`)
  * `List(ctx)` method that lists the cluster's High Availability groups

* feat(ha): added the `proxmox_virtual_environment_hagroups` data source

  * This data source returns the list of HA groups in its value's
    `group_ids` field

* fix(api): changed incorrect copy-pasted error message

* feat(api): get a HA group's full information

  * Added a `Get()` method to the HA group client, which fetches a
    single group's information based on its identifier.

* feat(ha): added the `proxmox_virtual_environment_hagroup` data source

  * This data source can read information about a single Proxmox High
    Availabillity group from the cluster.

* chore(ha): fixed linter error

* test(ha): added schema tests for the HA groups data sources

* fix(ha): use -1 as a node's priority when no priority is defined

  * It used to default to 0, which is a valid value for priorities.

* chore(ha): converted the `hagroups` datasource to the Terraform plugin SDK

* chore(refactoring): common definition for `id` attributes

* chore(ha): ported the HA group datasource to the Terraform plugin framework

* feat(ha): return HA group identifiers as a set rather than a list

* docs(ha): added examples for the hagroups/hagroup datasources

* docs(ha): added documentation for the hagroup{,s} datasources

* chore(ha): fixed linter errors

* chore(ha): workaround for the linter's split personality disorder

* fix(ha): fixed reading the restricted flag

* chore(refactoring): use `ExpandPath` for paths to the HA groups API

Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>

* feat: CustomBool to Terraform attribute value conversion method

* chore(refactoring): use `CustomBool` for boolean fields in the API data

* chore(refactoring): renamed "members" to "nodes" in the HA group datasource

* fix: typo in comment

* chore(refactoring): split HA group API data and added the update request body

* fix(api): fixed copy-pasted error message

* feat(api): method to create/update a HA group

* feat(api): HA group deletion method

* fix(api): made the digest optional for HA groups

* feat(ha): added unimplemented hagroup resource

* fix(ha): fixed copy-pasted comment

* feat(ha): schema definition for the HA group resource

* feat: helper function that converts string attr values to string pointers

* fix(ha): ensure node priorities are <= 1000 in HA groups

* fix(ha): add the digest attribute to the schema

* feat(ha): model definition for the HA group resource

* fix(api): fixed incorrect error message

* fix(api): fixed HA group creation / update

  * I had somehow misunderstood the Proxmox API doc and thought creation
    and update went through the same endpoint. This has been fixed by
    adding separate data structures and separate methods for both
    actions.

* feat: Terraform/Proxmox API conversion utilities

* chore(refactoring): HA group model and reading code moved to separate file

* feat(ha): HA group creation

* fix(api): renamed method (missed during previous refactor)

* feat(ha): `Read()` method implemented for the `hagroup` resource

* chore(refactoring): more consistent variable naming

* fix(ha): fixed the behaviour of `Read()` when the resource is deleted externally

* feat(ha): implement HA group deletion

* feat(ha): HA group update implemented

* fix(ha): prevent empty or untrimmed HA group comments

* feat(ha): HA group import

* docs(ha): HA group resource examples

* docs(ha): generated documentation for the `hagroup` resource

* chore(ha): fixed linter errors

* chore(refactoring): updated the code based on changes to the datasource PR

* fix(api): fixed boolean fields in the HA group create/update structures

* fix(ha): removed digest from the HA group resource and datasource

  * The digest is generated by Proxmox from the *whole* HA groups
    configuration, so any update to one group causes changes in all
    other groups.
  * Because of that, using it causes failures when updating two or more
    HA groups.
  * It is also a pretty useless value to have in the datasource, as it
    is global and not actually related to the individual data items

* chore(refactoring): removed obsolete type conversion code

* chore(refactoring): use `ExpandPath` in the HA groups API client

* feat(ha): custom type for HA resource states

* feat(ha): custom type for HA resource types

* fix(api): fixed JSON decoding for HA resource states and types

  * Values were being decoded directly from the raw bytes.
  * Added tests for JSON marshaling/unmarshaling

* feat(api): custom type for HA resource identifiers

  * Structure with a type and name
  * Conversion to/from strings
  * Marshaling to/Unmarshaling from JSON
  * URL encoding

* feat(api): list and get HA resources

* feat(ha): HA resources list datasource

* feat(ha): added method that converts HA resource data to Terraform values

* fix(api): HA resource max relocation/restarts are optional

* feat(ha): Terraform validator for HA resource IDs

* feat(ha): HA resource datasource

* chore(refactoring): moved HA resource model to separate file

* feat(api): data structures for HA resource creation and update

* feat(api): HA resource creation, update and deletion

* fix(api): incorrect mapping in common HA resource data

* feat: utility function to create attribute validators based on parse functions

* feat: validators for HA resource identifiers, states and types

* fix(api): incorrect comment for the update request body

* feat(ha): Terraform resource for Proxmox HA resources

* chore(reafactoring): removed old HA resource ID validator

* docs: examples related to HA resources added

* docs: added documentation related to HA resources management

* fix: update doc generation, fix minor typos

* fix: rename & split utils package, replace `iota`

---------

Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2023-08-20 21:42:12 +00:00
.github chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#480) 2023-08-10 20:24:06 +00:00
docs feat(ha): add support for Proxmox High Availability objects (#498) 2023-08-20 21:42:12 +00:00
example feat(vm): support for migration when the node name is modified (#501) 2023-08-18 22:02:50 -04:00
examples feat(ha): add support for Proxmox High Availability objects (#498) 2023-08-20 21:42:12 +00:00
internal feat(ha): add support for Proxmox High Availability objects (#498) 2023-08-20 21:42:12 +00:00
proxmox feat(ha): add support for Proxmox High Availability objects (#498) 2023-08-20 21:42:12 +00:00
proxmoxtf feat(vm): support for migration when the node name is modified (#501) 2023-08-18 22:02:50 -04:00
templates feat(core): migrate version datasource to TF plugin framework (#440) 2023-07-29 02:10:02 +00:00
tools feat(ha): add support for Proxmox High Availability objects (#498) 2023-08-20 21:42:12 +00:00
utils feat(vm): add network device resources (#376) 2023-06-23 22:47:25 +00:00
.all-contributorsrc docs: add michaelze as a contributor for code (#497) 2023-08-15 23:47:29 +00:00
.gitignore chore: update dependencies, cleanup docs (#446) 2023-07-30 16:24:53 +00:00
.golangci.yml feat(vm): add network device resources (#376) 2023-06-23 22:47:25 +00:00
.goreleaser.yml chore: new release workflow (#135) 2022-10-16 20:25:31 -04:00
.mergify.yml chore(mergify): update config (#166) 2022-11-17 20:38:49 -05:00
CHANGELOG.md chore(main): release 0.29.0 (#470) 2023-08-10 21:44:46 +00:00
CODE_OF_CONDUCT.md Update project to use bpg/terraform-provider-proxmox 2021-09-09 12:20:19 -04:00
commitlint.config.js chore: lint and reformat the code (#204) 2023-01-16 18:07:30 -05:00
CONTRIBUTING.md fix(lxc): add support for 'nixos' (#387) 2023-06-27 21:46:35 -04:00
example.tfrc fix(build): Fix make example-init for TF 1.4 (#262) 2023-03-16 22:09:41 -04:00
go.mod chore(deps): bump github.com/pkg/sftp from 1.13.5 to 1.13.6 (#488) 2023-08-13 11:05:12 -04:00
go.sum chore(deps): bump github.com/pkg/sftp from 1.13.5 to 1.13.6 (#488) 2023-08-13 11:05:12 -04:00
HISTORY.md tweak changelog generation 2021-09-09 07:25:06 -04:00
LICENSE Initial work 2019-12-07 19:58:29 +01:00
main.go feat(core): migrate version datasource to TF plugin framework (#440) 2023-07-29 02:10:02 +00:00
Makefile chore(main): release 0.29.0 (#470) 2023-08-10 21:44:46 +00:00
README.md docs: add michaelze as a contributor for code (#497) 2023-08-15 23:47:29 +00:00

Terraform Provider for Proxmox

Go Report Card GoDoc GitHub release (latest by date) GitHub Release Date GitHub stars All Contributors Conventional Commits Buy Me A Coffee

A Terraform Provider which adds support for Proxmox solutions.

This repository is a fork of https://github.com/danitso/terraform-provider-proxmox which is no longer maintained.

Compatibility promise

This provider is compatible with the latest version of Proxmox VE (currently 8.0). While it may work with older 7.x versions, it is not guaranteed to do so.

While provider is on version 0.x, it is not guaranteed to be backwards compatible with all previous minor versions. However, we will try to keep the backwards compatibility between provider versions as much as possible.

Requirements

  • Terraform 1.2+
  • Go 1.20+ (to build the provider plugin)

Building the provider

  • Clone the repository to $GOPATH/src/github.com/bpg/terraform-provider-proxmox:

    mkdir -p "${GOPATH}/src/github.com/bpg"
    cd "${GOPATH}/src/github.com/bpg"
    git clone git@github.com:bpg/terraform-provider-proxmox
    
  • Enter the provider directory and build it:

    cd "${GOPATH}/src/github.com/bpg/terraform-provider-proxmox"
    make build
    

Using the provider

You can find the latest release and its documentation in the Terraform Registry.

Testing the provider

In order to test the provider, you can simply run make test.

make test

Tests are limited to regression tests, ensuring backwards compatibility.

Deploying the example resources

There are number of TF examples in the examples directory, which can be used to deploy a Container, VM, or other Proxmox resources on your test Proxmox cluster. The following assumptions are made about the test Proxmox cluster:

  • It has one node named pve
  • The node has local storages named local and local-lvm

Create examples/terraform.tfvars with the following variables:

virtual_environment_username = "root@pam"
virtual_environment_password = "put-your-password-here"
virtual_environment_endpoint = "https://<your-cluster-endpoint>:8006/"

Then run make example to deploy the example resources.

Future work

The provider is using the Terraform SDKv2, which is considered legacy and is in maintenance mode. The work has started to migrate the provider to the new Terraform Plugin Framework, with aim to release it as a new major version 1.0.

Known issues

Disk images cannot be imported by non-PAM accounts

Due to limitations in the Proxmox VE API, certain actions need to be performed using SSH. This requires the use of a PAM account (standard Linux account).

Disk images from VMware cannot be uploaded or imported

Proxmox VE is not currently supporting VMware disk images directly. However, you can still use them as disk images by using this workaround:

resource "proxmox_virtual_environment_file" "vmdk_disk_image" {
  content_type = "iso"
  datastore_id = "datastore-id"
  node_name    = "node-name"

  source_file {
    # We must override the file extension to bypass the validation code
    # in the Proxmox VE API.
    file_name = "vmdk-file-name.img"
    path      = "path-to-vmdk-file"
  }
}

resource "proxmox_virtual_environment_vm" "example" {
  //...

  disk {
    datastore_id = "datastore-id"
    # We must tell the provider that the file format is vmdk instead of qcow2.
    file_format  = "vmdk"
    file_id      = "${proxmox_virtual_environment_file.vmdk_disk_image.id}"
  }

  //...
}

Snippets cannot be uploaded by non-PAM accounts

Due to limitations in the Proxmox VE API, certain files need to be uploaded using SFTP. This requires the use of a PAM account (standard Linux account).

Contributors

Dan R. Petersen
Dan R. Petersen

💻
Pavel Boldyrev
Pavel Boldyrev

💻 🚧
Lucas Hahn
Lucas Hahn

💻
Alex Kulikovskikh
Alex Kulikovskikh

💻
Oto Petřík
Oto Petřík

💻 💬 🐛
Boik
Boik

💻
Abdelfadeel Farag
Abdelfadeel Farag

💻
Szczepan Wiśniowski
Szczepan Wiśniowski

💻
Fabian Heib
Fabian Heib

💻
kaje783
kaje783

💻
michalg91
michalg91

💻
Cameron
Cameron

💻
Chris Jones
Chris Jones

💻
Dominik Wombacher
Dominik Wombacher

💻
Frank Villaro-Dixon
Frank Villaro-Dixon

💻
Gertjan Roggemans
Gertjan Roggemans

💻
Henri Williams
Henri Williams

💻
Jordan Keith
Jordan Keith

💻
Kai Kahllund
Kai Kahllund

💻
Kevin
Kevin

💻
Krzysztof Magosa
Krzysztof Magosa

💻
Matt Burchett
Matt Burchett

💻
Moyiz
Moyiz

💻
Pablo Escobar Lopez
Pablo Escobar Lopez

💻
Leah
Leah

💻
Pascal Wiedenbeck
Pascal Wiedenbeck

💻
Patrick Collins
Patrick Collins

💻
Prajwal
Prajwal

💻
Rafał Safin
Rafał Safin

💻
Remko Molier
Remko Molier

💻
Tuomas Salmi
Tuomas Salmi

💻
ikiris
ikiris

💻
mleone87
mleone87

💻
Ryan Yin
Ryan Yin

💻
zoop
zoop

💻
Simon Smith
Simon Smith

🐛 ⚠️
grzeg1
grzeg1

🐛
Moustafa Baiou
Moustafa Baiou

🐛 💻
dandaolrian
dandaolrian

💻
Dmitry
Dmitry

🐛
Michael Franzl
Michael Franzl

🐛
Emmanuel Benoît
Emmanuel Benoît

💻
mandrav
mandrav

💻 🐛
Michael Iseli
Michael Iseli

💻
Add your contributions

Stargazers

Star History Chart