0
0
mirror of https://github.com/bpg/terraform-provider-proxmox.git synced 2025-07-04 12:32:59 +00:00
terraform-provider-proxmox/proxmoxtf/resource/group.go
Pavel Boldyrev 98e1cff7fe
feat: Add firewall resources (#246)
* refactoring existing cluster / firewall API for better composition

* add basic security groups API
fix linter errors

* add rules API

* fix after renaming resourceVirtualEnvironmentClusterIPSet

* fix linter errors

* make linter happy

* even more refactoring

* tidy up datasources

* in refactoring spree

* update examples

* fix firewall resource/datasource & client error handling

* add ipset(s) datasource

* update docs

* add security group resource with rules

* docs

* fix security group update, TODO: rule update

* fix after rebase

* add rule update, extract common rule schema, refactor group

* fix linter  errors

* bump linter for ci

* make alias and ipset reusable

* make security group reusable

* refactor datasources

* add security group datasources

* fix linter errors

* update docs

TODO: documentation for group datasources

* add sg docs, update doc index

* minor cleanup

* fix examples & tests

* stub for firewall-level options and rules

* extract firewall interface

* add firewall options and rules on the cluster level

TODO: issues with rule list management

* refactor all resources format AGAIN, now more flat, without complex subresources

* sort out hierarchy of APIs and remove duplication in API wrappers

* bring back security group

* finally, working rules

* restore cluster firewall option

* add containers support

* add options

* move rules back under security group, update docs

* fix vm_id / container_id attrs

* add examples

* cleanup

* more cleanup


Release-As: 0.17.0-rc1
2023-04-02 18:01:10 -04:00

314 lines
8.4 KiB
Go

/*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
*/
package resource
import (
"context"
"strings"
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/bpg/terraform-provider-proxmox/proxmox"
"github.com/bpg/terraform-provider-proxmox/proxmox/types"
"github.com/bpg/terraform-provider-proxmox/proxmoxtf"
)
const (
dvResourceVirtualEnvironmentGroupComment = ""
mkResourceVirtualEnvironmentGroupACL = "acl"
mkResourceVirtualEnvironmentGroupACLPath = "path"
mkResourceVirtualEnvironmentGroupACLPropagate = "propagate"
mkResourceVirtualEnvironmentGroupACLRoleID = "role_id"
mkResourceVirtualEnvironmentGroupComment = "comment"
mkResourceVirtualEnvironmentGroupID = "group_id"
mkResourceVirtualEnvironmentGroupMembers = "members"
)
func Group() *schema.Resource {
return &schema.Resource{
Schema: map[string]*schema.Schema{
mkResourceVirtualEnvironmentGroupACL: {
Type: schema.TypeSet,
Description: "The access control list",
Optional: true,
DefaultFunc: func() (interface{}, error) {
return []interface{}{}, nil
},
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
mkResourceVirtualEnvironmentGroupACLPath: {
Type: schema.TypeString,
Required: true,
Description: "The path",
},
mkResourceVirtualEnvironmentGroupACLPropagate: {
Type: schema.TypeBool,
Optional: true,
Description: "Whether to propagate to child paths",
Default: false,
},
mkResourceVirtualEnvironmentGroupACLRoleID: {
Type: schema.TypeString,
Required: true,
Description: "The role id",
},
},
},
},
mkResourceVirtualEnvironmentGroupComment: {
Type: schema.TypeString,
Description: "The group comment",
Optional: true,
Default: dvResourceVirtualEnvironmentGroupComment,
},
mkResourceVirtualEnvironmentGroupID: {
Type: schema.TypeString,
Description: "The group id",
Required: true,
ForceNew: true,
},
mkResourceVirtualEnvironmentGroupMembers: {
Type: schema.TypeSet,
Description: "The group members",
Computed: true,
Elem: &schema.Schema{Type: schema.TypeString},
},
},
CreateContext: groupCreate,
ReadContext: groupRead,
UpdateContext: groupUpdate,
DeleteContext: groupDelete,
}
}
func groupCreate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
config := m.(proxmoxtf.ProviderConfiguration)
veClient, err := config.GetVEClient()
if err != nil {
return diag.FromErr(err)
}
comment := d.Get(mkResourceVirtualEnvironmentGroupComment).(string)
groupID := d.Get(mkResourceVirtualEnvironmentGroupID).(string)
body := &proxmox.VirtualEnvironmentGroupCreateRequestBody{
Comment: &comment,
ID: groupID,
}
err = veClient.CreateGroup(ctx, body)
if err != nil {
return diag.FromErr(err)
}
d.SetId(groupID)
aclParsed := d.Get(mkResourceVirtualEnvironmentGroupACL).(*schema.Set).List()
for _, v := range aclParsed {
aclDelete := types.CustomBool(false)
aclEntry := v.(map[string]interface{})
aclPropagate := types.CustomBool(
aclEntry[mkResourceVirtualEnvironmentGroupACLPropagate].(bool),
)
aclBody := &proxmox.VirtualEnvironmentACLUpdateRequestBody{
Delete: &aclDelete,
Groups: []string{groupID},
Path: aclEntry[mkResourceVirtualEnvironmentGroupACLPath].(string),
Propagate: &aclPropagate,
Roles: []string{aclEntry[mkResourceVirtualEnvironmentGroupACLRoleID].(string)},
}
err := veClient.UpdateACL(ctx, aclBody)
if err != nil {
return diag.FromErr(err)
}
}
return groupRead(ctx, d, m)
}
func groupRead(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
var diags diag.Diagnostics
config := m.(proxmoxtf.ProviderConfiguration)
veClient, err := config.GetVEClient()
if err != nil {
return diag.FromErr(err)
}
groupID := d.Id()
group, err := veClient.GetGroup(ctx, groupID)
if err != nil {
if strings.Contains(err.Error(), "HTTP 404") {
d.SetId("")
return nil
}
return diag.FromErr(err)
}
acl, err := veClient.GetACL(ctx)
if err != nil {
return diag.FromErr(err)
}
var aclParsed []interface{}
for _, v := range acl {
if v.Type == "group" && v.UserOrGroupID == groupID {
aclEntry := map[string]interface{}{}
aclEntry[mkResourceVirtualEnvironmentGroupACLPath] = v.Path
if v.Propagate != nil {
aclEntry[mkResourceVirtualEnvironmentGroupACLPropagate] = bool(*v.Propagate)
} else {
aclEntry[mkResourceVirtualEnvironmentGroupACLPropagate] = false
}
aclEntry[mkResourceVirtualEnvironmentGroupACLRoleID] = v.RoleID
aclParsed = append(aclParsed, aclEntry)
}
}
err = d.Set(mkResourceVirtualEnvironmentGroupACL, aclParsed)
diags = append(diags, diag.FromErr(err)...)
if group.Comment != nil {
err = d.Set(mkResourceVirtualEnvironmentGroupComment, group.Comment)
} else {
err = d.Set(mkResourceVirtualEnvironmentGroupComment, "")
}
diags = append(diags, diag.FromErr(err)...)
err = d.Set(mkResourceVirtualEnvironmentGroupMembers, group.Members)
diags = append(diags, diag.FromErr(err)...)
return diags
}
func groupUpdate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
config := m.(proxmoxtf.ProviderConfiguration)
veClient, err := config.GetVEClient()
if err != nil {
return diag.FromErr(err)
}
comment := d.Get(mkResourceVirtualEnvironmentGroupComment).(string)
groupID := d.Id()
body := &proxmox.VirtualEnvironmentGroupUpdateRequestBody{
Comment: &comment,
}
err = veClient.UpdateGroup(ctx, groupID, body)
if err != nil {
return diag.FromErr(err)
}
aclArgOld, aclArg := d.GetChange(mkResourceVirtualEnvironmentGroupACL)
aclParsedOld := aclArgOld.(*schema.Set).List()
for _, v := range aclParsedOld {
aclDelete := types.CustomBool(true)
aclEntry := v.(map[string]interface{})
aclPropagate := types.CustomBool(
aclEntry[mkResourceVirtualEnvironmentGroupACLPropagate].(bool),
)
aclBody := &proxmox.VirtualEnvironmentACLUpdateRequestBody{
Delete: &aclDelete,
Groups: []string{groupID},
Path: aclEntry[mkResourceVirtualEnvironmentGroupACLPath].(string),
Propagate: &aclPropagate,
Roles: []string{aclEntry[mkResourceVirtualEnvironmentGroupACLRoleID].(string)},
}
err := veClient.UpdateACL(ctx, aclBody)
if err != nil {
return diag.FromErr(err)
}
}
aclParsed := aclArg.(*schema.Set).List()
for _, v := range aclParsed {
aclDelete := types.CustomBool(false)
aclEntry := v.(map[string]interface{})
aclPropagate := types.CustomBool(
aclEntry[mkResourceVirtualEnvironmentGroupACLPropagate].(bool),
)
aclBody := &proxmox.VirtualEnvironmentACLUpdateRequestBody{
Delete: &aclDelete,
Groups: []string{groupID},
Path: aclEntry[mkResourceVirtualEnvironmentGroupACLPath].(string),
Propagate: &aclPropagate,
Roles: []string{aclEntry[mkResourceVirtualEnvironmentGroupACLRoleID].(string)},
}
err := veClient.UpdateACL(ctx, aclBody)
if err != nil {
return diag.FromErr(err)
}
}
return groupRead(ctx, d, m)
}
func groupDelete(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
config := m.(proxmoxtf.ProviderConfiguration)
veClient, err := config.GetVEClient()
if err != nil {
return diag.FromErr(err)
}
aclParsed := d.Get(mkResourceVirtualEnvironmentGroupACL).(*schema.Set).List()
groupID := d.Id()
for _, v := range aclParsed {
aclDelete := types.CustomBool(true)
aclEntry := v.(map[string]interface{})
aclPropagate := types.CustomBool(
aclEntry[mkResourceVirtualEnvironmentGroupACLPropagate].(bool),
)
aclBody := &proxmox.VirtualEnvironmentACLUpdateRequestBody{
Delete: &aclDelete,
Groups: []string{groupID},
Path: aclEntry[mkResourceVirtualEnvironmentGroupACLPath].(string),
Propagate: &aclPropagate,
Roles: []string{aclEntry[mkResourceVirtualEnvironmentGroupACLRoleID].(string)},
}
err := veClient.UpdateACL(ctx, aclBody)
if err != nil {
return diag.FromErr(err)
}
}
err = veClient.DeleteGroup(ctx, groupID)
if err != nil {
if strings.Contains(err.Error(), "HTTP 404") {
d.SetId("")
return nil
}
return diag.FromErr(err)
}
d.SetId("")
return nil
}