mirror of
https://github.com/bpg/terraform-provider-proxmox.git
synced 2025-06-30 02:31:10 +00:00
3195b3cdf4
* feat(file)!: safer snippets upload using SSH input stream * fixes for acceptance tests on windows * enable other OS-es for acceptance tests * update example templates to use api token auth --------- Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
287 lines
8.1 KiB
Go
287 lines
8.1 KiB
Go
/*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
package tests
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/url"
|
|
"os"
|
|
"path/filepath"
|
|
"regexp"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/brianvoe/gofakeit/v7"
|
|
|
|
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/bpg/terraform-provider-proxmox/proxmox/api"
|
|
"github.com/bpg/terraform-provider-proxmox/proxmox/ssh"
|
|
|
|
"github.com/bpg/terraform-provider-proxmox/utils"
|
|
)
|
|
|
|
const (
|
|
accTestFileRawName = "proxmox_virtual_environment_file.test_raw"
|
|
accTestFileName = "proxmox_virtual_environment_file.test"
|
|
)
|
|
|
|
type nodeResolver struct {
|
|
node ssh.ProxmoxNode
|
|
}
|
|
|
|
func (c *nodeResolver) Resolve(_ context.Context, _ string) (ssh.ProxmoxNode, error) {
|
|
return c.node, nil
|
|
}
|
|
|
|
func TestAccResourceFile(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
accProviders := testAccMuxProviders(context.Background(), t)
|
|
|
|
snippetRaw := fmt.Sprintf("snippet-raw-%s.txt", gofakeit.Word())
|
|
snippetURL := "https://raw.githubusercontent.com/yaml/yaml-test-suite/main/src/229Q.yaml"
|
|
snippetFile1 := createFile(t, "snippet-file-1-*.yaml", "test snippet 1 - file")
|
|
snippetFile2 := createFile(t, "snippet-file-2-*.yaml", "test snippet 2 - file")
|
|
fileISO := createFile(t, "file-*.iso", "pretend it is an ISO")
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
ProtoV6ProviderFactories: accProviders,
|
|
PreCheck: func() {
|
|
uploadSnippetFile(t, snippetFile2)
|
|
},
|
|
Steps: []resource.TestStep{
|
|
{
|
|
Config: testAccResourceFileSnippetRawCreatedConfig(t, snippetRaw),
|
|
Check: testAccResourceFileSnippetRawCreatedCheck(snippetRaw),
|
|
},
|
|
{
|
|
Config: testAccResourceFileCreatedConfig(t, snippetFile1.Name()),
|
|
Check: testAccResourceFileCreatedCheck("snippets", snippetFile1.Name()),
|
|
},
|
|
{
|
|
Config: testAccResourceFileCreatedConfig(t, snippetURL),
|
|
Check: testAccResourceFileCreatedCheck("snippets", snippetURL),
|
|
},
|
|
{
|
|
Config: testAccResourceFileCreatedConfig(t, fileISO.Name()),
|
|
Check: testAccResourceFileCreatedCheck("iso", fileISO.Name()),
|
|
},
|
|
{
|
|
Config: testAccResourceFileTwoSourcesCreatedConfig(t),
|
|
ExpectError: regexp.MustCompile("please specify .* - not both"),
|
|
},
|
|
{
|
|
Config: testAccResourceFileCreatedConfig(t, "https://github.com", "content_type = \"iso\""),
|
|
ExpectError: regexp.MustCompile("failed to determine file name from the URL"),
|
|
},
|
|
{
|
|
Config: testAccResourceFileMissingSourceConfig(t),
|
|
ExpectError: regexp.MustCompile("missing argument"),
|
|
},
|
|
// Do not allow to overwrite the file
|
|
{
|
|
Config: testAccResourceFileCreatedConfig(t, snippetFile2.Name(), "overwrite = false"),
|
|
ExpectError: regexp.MustCompile("already exists"),
|
|
},
|
|
// Allow to overwrite the file by default
|
|
{
|
|
Config: testAccResourceFileCreatedConfig(t, snippetFile2.Name()),
|
|
Check: testAccResourceFileCreatedCheck("snippets", snippetFile2.Name()),
|
|
},
|
|
// Update testing
|
|
{
|
|
PreConfig: func() {
|
|
deleteSnippet(t, filepath.Base(snippetFile1.Name()))
|
|
},
|
|
Config: testAccResourceFileSnippetUpdateConfig(t, snippetFile1.Name()),
|
|
Check: testAccResourceFileSnippetUpdatedCheck(snippetFile1.Name()),
|
|
},
|
|
// ImportState testing
|
|
{
|
|
ResourceName: accTestFileName,
|
|
ImportState: true,
|
|
ImportStateVerify: true,
|
|
ImportStateId: fmt.Sprintf("pve/local:snippets/%s", filepath.Base(snippetFile2.Name())),
|
|
SkipFunc: func() (bool, error) {
|
|
// doesn't work, not sure why
|
|
return true, nil
|
|
},
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
func uploadSnippetFile(t *testing.T, file *os.File) {
|
|
t.Helper()
|
|
|
|
endpoint := utils.GetAnyStringEnv("PROXMOX_VE_ENDPOINT")
|
|
u, err := url.ParseRequestURI(endpoint)
|
|
require.NoError(t, err)
|
|
|
|
sshAgent := utils.GetAnyBoolEnv("PROXMOX_VE_SSH_AGENT")
|
|
sshUsername := utils.GetAnyStringEnv("PROXMOX_VE_SSH_USERNAME")
|
|
sshAgentSocket := utils.GetAnyStringEnv("SSH_AUTH_SOCK", "PROXMOX_VE_SSH_AUTH_SOCK")
|
|
sshPrivateKey := utils.GetAnyStringEnv("PROXMOX_VE_SSH_PRIVATE_KEY")
|
|
sshClient, err := ssh.NewClient(
|
|
sshUsername, "", sshAgent, sshAgentSocket, sshPrivateKey,
|
|
"", "", "",
|
|
&nodeResolver{
|
|
node: ssh.ProxmoxNode{
|
|
Address: u.Hostname(),
|
|
Port: 22,
|
|
},
|
|
},
|
|
)
|
|
require.NoError(t, err)
|
|
|
|
f, err := os.Open(file.Name())
|
|
require.NoError(t, err)
|
|
|
|
defer f.Close()
|
|
|
|
fname := filepath.Base(file.Name())
|
|
err = sshClient.NodeStreamUpload(context.Background(), "pve", "/var/lib/vz/",
|
|
&api.FileUploadRequest{
|
|
ContentType: "snippets",
|
|
FileName: fname,
|
|
File: f,
|
|
})
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func createFile(t *testing.T, namePattern string, content string) *os.File {
|
|
t.Helper()
|
|
|
|
f, err := os.CreateTemp("", namePattern)
|
|
require.NoError(t, err)
|
|
|
|
_, err = f.WriteString(content)
|
|
require.NoError(t, err)
|
|
|
|
defer f.Close()
|
|
|
|
t.Cleanup(func() {
|
|
_ = os.Remove(f.Name())
|
|
})
|
|
|
|
return f
|
|
}
|
|
|
|
func deleteSnippet(t *testing.T, fname string) {
|
|
t.Helper()
|
|
|
|
err := getNodeStorageClient().DeleteDatastoreFile(context.Background(), fmt.Sprintf("snippets/%s", fname))
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func testAccResourceFileSnippetRawCreatedConfig(t *testing.T, fname string) string {
|
|
t.Helper()
|
|
|
|
return fmt.Sprintf(`%s
|
|
resource "proxmox_virtual_environment_file" "test_raw" {
|
|
content_type = "snippets"
|
|
datastore_id = "local"
|
|
node_name = "%s"
|
|
source_raw {
|
|
data = <<EOF
|
|
test snippet
|
|
EOF
|
|
file_name = "%s"
|
|
}
|
|
}
|
|
`, getProviderConfig(t), accTestNodeName, fname)
|
|
}
|
|
|
|
func testAccResourceFileCreatedConfig(t *testing.T, fname string, extra ...string) string {
|
|
t.Helper()
|
|
|
|
return fmt.Sprintf(`%s
|
|
resource "proxmox_virtual_environment_file" "test" {
|
|
datastore_id = "local"
|
|
node_name = "%s"
|
|
source_file {
|
|
path = "%s"
|
|
}
|
|
%s
|
|
}
|
|
`, getProviderConfig(t), accTestNodeName, strings.ReplaceAll(fname, `\`, `/`), strings.Join(extra, "\n"))
|
|
}
|
|
|
|
func testAccResourceFileTwoSourcesCreatedConfig(t *testing.T) string {
|
|
t.Helper()
|
|
|
|
return fmt.Sprintf(`%s
|
|
resource "proxmox_virtual_environment_file" "test" {
|
|
datastore_id = "local"
|
|
node_name = "%s"
|
|
source_raw {
|
|
data = <<EOF
|
|
test snippet
|
|
EOF
|
|
file_name = "foo.yaml"
|
|
}
|
|
source_file {
|
|
path = "bar.yaml"
|
|
}
|
|
}
|
|
`, getProviderConfig(t), accTestNodeName)
|
|
}
|
|
|
|
func testAccResourceFileMissingSourceConfig(t *testing.T) string {
|
|
t.Helper()
|
|
|
|
return fmt.Sprintf(`%s
|
|
resource "proxmox_virtual_environment_file" "test" {
|
|
datastore_id = "local"
|
|
node_name = "%s"
|
|
}
|
|
`, getProviderConfig(t), accTestNodeName)
|
|
}
|
|
|
|
func testAccResourceFileSnippetRawCreatedCheck(fname string) resource.TestCheckFunc {
|
|
return resource.ComposeTestCheckFunc(
|
|
resource.TestCheckResourceAttr(accTestFileRawName, "content_type", "snippets"),
|
|
resource.TestCheckResourceAttr(accTestFileRawName, "file_name", fname),
|
|
resource.TestCheckResourceAttr(accTestFileRawName, "source_raw.0.file_name", fname),
|
|
resource.TestCheckResourceAttr(accTestFileRawName, "source_raw.0.data", "test snippet\n"),
|
|
resource.TestCheckResourceAttr(accTestFileRawName, "id", fmt.Sprintf("local:snippets/%s", fname)),
|
|
)
|
|
}
|
|
|
|
func testAccResourceFileCreatedCheck(ctype string, fname string) resource.TestCheckFunc {
|
|
return resource.ComposeTestCheckFunc(
|
|
resource.TestCheckResourceAttr(accTestFileName, "content_type", ctype),
|
|
resource.TestCheckResourceAttr(accTestFileName, "file_name", filepath.Base(fname)),
|
|
resource.TestCheckResourceAttr(accTestFileName, "id", fmt.Sprintf("local:%s/%s", ctype, filepath.Base(fname))),
|
|
)
|
|
}
|
|
|
|
func testAccResourceFileSnippetUpdateConfig(t *testing.T, fname string) string {
|
|
t.Helper()
|
|
|
|
return fmt.Sprintf(`%s
|
|
resource "proxmox_virtual_environment_file" "test" {
|
|
datastore_id = "local"
|
|
node_name = "%s"
|
|
source_file {
|
|
path = "%s"
|
|
}
|
|
}
|
|
`, getProviderConfig(t), accTestNodeName, strings.ReplaceAll(fname, `\`, `/`))
|
|
}
|
|
|
|
func testAccResourceFileSnippetUpdatedCheck(fname string) resource.TestCheckFunc {
|
|
return resource.ComposeTestCheckFunc(
|
|
resource.TestCheckResourceAttr(accTestFileName, "content_type", "snippets"),
|
|
resource.TestCheckResourceAttr(accTestFileName, "file_name", filepath.Base(fname)),
|
|
resource.TestCheckResourceAttr(accTestFileName, "id", fmt.Sprintf("local:%s/%s", "snippets", filepath.Base(fname))),
|
|
)
|
|
}
|