0
0
mirror of https://github.com/bpg/terraform-provider-proxmox.git synced 2025-06-30 10:33:46 +00:00
Terraform / OpenTofu Provider for Proxmox VE
Go to file
Sven Greb 76c1c2282b
feat(cluster): Implement initial support for "hardware mappings" (#1213)
* feat(cluster): Implement initial support for "hardware mappings"

Right now it is alredy possible to use a mapped resource [1], but there
is no dedicated `proxmox_virtual_environment_cluster_hardware_mapping`
resource but this step must still be done manually (or automated through
other ways that interact with the Proxmox API).

This commit implements support for "hardware mapping" resources and data
sources for the, currently, available bus types PCI and USB, based on
the Proxmox VE API documentations [2].

There are some "specialities" in these resources and data sources:

1. The Proxmox VE API attribute, but this implementations names it
   "comment" since this naming is generally across the Proxmox VE web UI
   and API documentations. This still follows the Terraform
   "best practices" [3] as it improves the user experience by matching
   the field name to the naming used in the human-facing interfaces.

2. Like in point 1, the name of the attribute of "node checks
   diagnostics" for USB hardware mappings is "errors" in the Proxmox VE
   API while it is "checks" for hardware mappings of type PCI.
   The second naming pattern is also generally used across the
   Proxmox VE web UI and API documentations, including the "check_node"
   attribute that is also implemented in the
   "proxmox_virtual_environment_hardware_mappings" data source.
   Therefore, this implementation named both attributes "checks" which
   still follows the Terraform "best practices" [3] as it improves the
   user experience by matching the field name to the naming used in the
   human-facing interfaces.
3. This implmenetation comes with the "unique" feature of allowing
   comments (named "descriptions" by the Proxmox VE API) for an entry in
   a device map which is not possible through the web UI at all but only
   adding a comment for the whole mapping entry instead.

Note that this implementation also adds another point in the
"Known Issues" documentation since it is only possible to map a
PCI/USB device using the `root` PAM account, but this is still better
than having to manually configure it through the web UI or by
interacting with the Proxmox VE API on other ways.

[1]: https://github.com/bpg/terraform-provider-proxmox/pull/500
[2]: https://pve.proxmox.com/pve-docs/api-viewer/#/cluster/mapping/pci
[3]: https://developer.hashicorp.com/terraform/plugin/best-practices/hashicorp-provider-design-principles#resource-and-attribute-schema-should-closely-match-the-underlying-api

Signed-off-by: Sven Greb <development@svengreb.de>

* fix linter

Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>

---------

Signed-off-by: Sven Greb <development@svengreb.de>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-18 16:00:51 -04:00
.devcontainer chore(vm): refactoring, add acceptance tests (#1040) 2024-02-19 16:56:13 -05:00
.github misc: do not auto-dispatch acceptance tests 2024-04-09 22:39:10 -04:00
.vscode fix(vm): state drift due to disk re-ordering (#1215) 2024-04-15 16:45:38 -04:00
docs feat(cluster): Implement initial support for "hardware mappings" (#1213) 2024-04-18 16:00:51 -04:00
example fix(vm): error 'resizing of efidisks is not supported' when clonning a VM with re-defined efi_disk (#1206) 2024-04-11 23:09:56 -04:00
examples feat(cluster): Implement initial support for "hardware mappings" (#1213) 2024-04-18 16:00:51 -04:00
fwprovider feat(cluster): Implement initial support for "hardware mappings" (#1213) 2024-04-18 16:00:51 -04:00
proxmox feat(cluster): Implement initial support for "hardware mappings" (#1213) 2024-04-18 16:00:51 -04:00
proxmoxtf fix(vm): state drift due to disk re-ordering (#1215) 2024-04-15 16:45:38 -04:00
templates feat(file): add overwrite_unmanaged attribute to virtual_environment_download_file resource (#1064) 2024-02-25 21:33:17 -05:00
tools feat(cluster): Implement initial support for "hardware mappings" (#1213) 2024-04-18 16:00:51 -04:00
utils fix(vm): state drift due to disk re-ordering (#1215) 2024-04-15 16:45:38 -04:00
.all-contributorsrc docs: add tyxieblub as a contributor for code (#1210) 2024-04-11 23:11:40 -04:00
.gitignore fix(docs): update HOW-TOs for cloud-init (#955) 2024-01-24 03:44:39 +00:00
.golangci.yml feat(cluster): Implement initial support for "hardware mappings" (#1213) 2024-04-18 16:00:51 -04:00
.goreleaser.yml misc: cleanup .gorelease.yml 2024-03-12 22:02:02 -04:00
.lycheeignore misc: add .lycheeignore 2024-01-20 23:18:36 -05:00
.markdownlint.json chore(docs): update README.md (#1045) 2024-02-20 00:05:54 +00:00
.markdownlintignore feat(provider): add DNS lookup fallback for node IP resolution (#848) 2023-12-29 12:24:36 -05:00
.mergify.yml misc(ci): update .mergify.yml (#1024) 2024-02-08 22:52:37 -05:00
.release-please-manifest.json chore(main): release 0.53.1 (#1208) 2024-04-11 23:19:17 -04:00
CHANGELOG.md chore(main): release 0.53.1 (#1208) 2024-04-11 23:19:17 -04:00
CODE_OF_CONDUCT.md Update project to use bpg/terraform-provider-proxmox 2021-09-09 12:20:19 -04:00
commitlint.config.js chore: lint and reformat the code (#204) 2023-01-16 18:07:30 -05:00
CONTRIBUTING.md chore: improve acceptance tests on CI (#1173) 2024-04-07 04:41:57 +00:00
CONTRIBUTORS.md docs: add tyxieblub as a contributor for code (#1210) 2024-04-11 23:11:40 -04:00
example.tfrc fix(build): Fix make example-init for TF 1.4 (#262) 2023-03-16 22:09:41 -04:00
go.mod chore(deps): update golang.org/x/exp digest (c0f41cb → 93d18d7) (#1201) 2024-04-10 02:12:52 +00:00
go.sum chore(deps): update golang.org/x/exp digest (c0f41cb → 93d18d7) (#1201) 2024-04-10 02:12:52 +00:00
HISTORY.md tweak changelog generation 2021-09-09 07:25:06 -04:00
LICENSE Initial work 2019-12-07 19:58:29 +01:00
main.go fix(provider): EOF error when closing SSH session (#1113) 2024-03-11 20:05:11 -04:00
Makefile chore(main): release 0.53.1 (#1208) 2024-04-11 23:19:17 -04:00
README.md feat(cluster): Implement initial support for "hardware mappings" (#1213) 2024-04-18 16:00:51 -04:00
release-please-config.json fix(docs): fix documentation tree structure in the TF registry (#980) 2024-01-27 22:16:53 -05:00
terraform-registry-manifest.json fix(ci): missing releases from HashiCorp Registry (#1118) 2024-03-13 01:48:05 +00:00
testacc feat(vm): add support for numa architecture attribute (#1156) (#1175) 2024-04-06 16:30:13 -04:00

Terraform Provider for Proxmox

Go Report Card GoDoc GitHub release (latest by date) GitHub Release Date GitHub stars All Contributors Conventional Commits Buy Me A Coffee

A Terraform / OpenTofu Provider which adds support for Proxmox solutions.

This repository is a fork of https://github.com/danitso/terraform-provider-proxmox which is no longer maintained.

Compatibility promise

This provider is compatible with the latest version of Proxmox VE (currently 8.1). While it may work with older 7.x versions, it is not guaranteed to do so.

While provider is on version 0.x, it is not guaranteed to be backwards compatible with all previous minor versions. However, we will try to keep the backwards compatibility between provider versions as much as possible.

Requirements

Using the provider

You can find the latest release and its documentation in the Terraform Registry.

Testing the provider

In order to test the provider, you can simply run make test.

make test

Tests are limited to regression tests, ensuring backwards compatibility.

A limited number of acceptance tests are available in the proxmoxtf/test directory, mostly for "new" functionality implemented using the Terraform Provider Framework. These tests are not run by default, as they require a Proxmox VE environment to be available. They can be run using make testacc, the Proxmox connection can be configured using environment variables, see provider documentation for details.

Deploying the example resources

There are number of TF examples in the example directory, which can be used to deploy a Container, VM, or other Proxmox resources on your test Proxmox environment. The following assumptions are made about the test environment:

  • It has one node named pve
  • The node has local storages named local and local-lvm
  • The "Snippets" content type is enabled in local storage

Create example/terraform.tfvars with the following variables:

virtual_environment_username = "root@pam"
virtual_environment_password = "put-your-password-here"
virtual_environment_endpoint = "https://<your-cluster-endpoint>:8006/"

Then run make example to deploy the example resources.

If you don't have free proxmox cluster to play with, there is dedicated how-to tutorial how to setup Proxmox inside VM and run make example on it.

Future work

The provider is using the Terraform SDKv2, which is considered legacy and is in maintenance mode. The work has started to migrate the provider to the new Terraform Plugin Framework, with aim to release it as a new major version 1.0.

Known issues

Disk images cannot be imported by non-PAM accounts

Due to limitations in the Proxmox VE API, certain actions need to be performed using SSH. This requires the use of a PAM account (standard Linux account).

Disk images from VMware cannot be uploaded or imported

Proxmox VE is not currently supporting VMware disk images directly. However, you can still use them as disk images by using this workaround:

resource "proxmox_virtual_environment_file" "vmdk_disk_image" {
  content_type = "iso"
  datastore_id = "datastore-id"
  node_name    = "node-name"

  source_file {
    # We must override the file extension to bypass the validation code
    # in the Proxmox VE API.
    file_name = "vmdk-file-name.img"
    path      = "path-to-vmdk-file"
  }
}

resource "proxmox_virtual_environment_vm" "example" {
  //...

  disk {
    datastore_id = "datastore-id"
    # We must tell the provider that the file format is vmdk instead of qcow2.
    file_format  = "vmdk"
    file_id      = "${proxmox_virtual_environment_file.vmdk_disk_image.id}"
  }

  //...
}

Snippets cannot be uploaded by non-PAM accounts

Due to limitations in the Proxmox VE API, certain files (snippets, backups) need to be uploaded using SFTP. This requires the use of a PAM account (standard Linux account).

Cluster hardware mappings cannot be created by non-PAM accounts

Due to limitations in the Proxmox VE API, cluster hardware mappings must be created using the root PAM account (standard Linux account) due to IOMMU interactions. Hardware mappings allow to use PCI "passthrough" and map physical USB ports.

Contributors

See CONTRIBUTORS.md for a list of contributors to this project.

Repository Metrics

Metrics

Sponsorship

❤️ This project is sponsored by:

Thanks again for your support, it is much appreciated! 🙏