mirror of
https://github.com/bpg/terraform-provider-proxmox.git
synced 2025-07-01 11:02:59 +00:00
* feat(file): Add support to set the file mode GH-733 [1] implemented basic support for hook scripts, but the authors "did not manage to find time to work on" [2] also including support to set the file mode. This small but important feature makes the use of the `proxmox_virtual_environment_container.hook_script_file_id` [3] and `virtual_environment_vm.hook_script_file_id` [34] attributes basically useless when not combined with the manual step of making the uploaded file executable (manually running `chmod +x /path/to/script` or using other methods, based on the storage backend). Using the `hook_script_file_id` on its own also causes all planned and applies changes in the same execution to not be saved in the state because the Proxmox VE API responses with a HTTP `500` because the uploaded and assigned file is not executable. This pull request implements the missing feature to set the file mode by adding a new `file_mode` attribute of type `string` where an octal-formatted value can be passed, e.g. `0700` or only `600`. Note that the support for the octal prefixes `0o` and `0x` are not supported to reduced the complexity, even though Go of course support it, including the used `os.FileMode` type [5]. Changing the file mode also causes the file to be replaced, which is true for almost any attribute in the `proxmox_virtual_environment_file` resource, to ensure that the file mode can also be changed after the initial creation. [1]: https://github.com/bpg/terraform-provider-proxmox/pull/733 [2]: https://github.com/bpg/terraform-provider-proxmox/pull/733#issuecomment-2096716738 [3]: https://registry.terraform.io/providers/bpg/proxmox/latest/docs/resources/virtual_environment_container#hook_script_file_id [4]: https://registry.terraform.io/providers/bpg/proxmox/latest/docs/resources/virtual_environment_vm#hook_script_file_id [5]: https://pkg.go.dev/os#FileMode Related to GH-570 Related to GH-733 Signed-off-by: Sven Greb <development@svengreb.de> --------- Signed-off-by: Sven Greb <development@svengreb.de>
122 lines
2.9 KiB
Go
122 lines
2.9 KiB
Go
/*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
package validators
|
|
|
|
import (
|
|
"fmt"
|
|
"regexp"
|
|
"strconv"
|
|
|
|
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
|
|
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
|
|
|
|
"github.com/bpg/terraform-provider-proxmox/proxmox/types"
|
|
)
|
|
|
|
// ContentType returns a schema validation function for a content type on a storage device.
|
|
func ContentType() schema.SchemaValidateDiagFunc {
|
|
return validation.ToDiagFunc(validation.StringInSlice([]string{
|
|
"dump",
|
|
"iso",
|
|
"snippets",
|
|
"vztmpl",
|
|
}, false))
|
|
}
|
|
|
|
// FileFormat returns a schema validation function for a file format.
|
|
func FileFormat() schema.SchemaValidateDiagFunc {
|
|
return validation.ToDiagFunc(validation.StringInSlice([]string{
|
|
"qcow2",
|
|
"raw",
|
|
"vmdk",
|
|
}, false))
|
|
}
|
|
|
|
// FileID returns a schema validation function for a file identifier.
|
|
func FileID() schema.SchemaValidateDiagFunc {
|
|
return validation.ToDiagFunc(func(i interface{}, k string) ([]string, []error) {
|
|
v, ok := i.(string)
|
|
|
|
var ws []string
|
|
|
|
var es []error
|
|
|
|
if !ok {
|
|
es = append(es, fmt.Errorf("expected type of %s to be string", k))
|
|
return ws, es
|
|
}
|
|
|
|
if v != "" {
|
|
r := regexp.MustCompile(`^(?i)[a-z\d\-_.]+:([a-z\d\-_]+/)?.+$`)
|
|
ok := r.MatchString(v)
|
|
|
|
if !ok {
|
|
es = append(es, fmt.Errorf(
|
|
"expected %s to be a valid file identifier (datastore-name:iso/some-file.img), got %s", k, v,
|
|
))
|
|
|
|
return ws, es
|
|
}
|
|
}
|
|
|
|
return ws, es
|
|
})
|
|
}
|
|
|
|
// FileMode is a schema validation function for file mode.
|
|
func FileMode() schema.SchemaValidateDiagFunc {
|
|
return validation.ToDiagFunc(
|
|
func(i interface{}, k string) ([]string, []error) {
|
|
var errs []error
|
|
|
|
v, ok := i.(string)
|
|
if !ok {
|
|
errs = append(errs, fmt.Errorf(
|
|
`expected string in octal format (e.g. "0o700" or "0700"") for %q, but got %v of type %T`, k, v, i))
|
|
return nil, errs
|
|
}
|
|
|
|
mode, err := strconv.ParseInt(v, 10, 64)
|
|
if err != nil {
|
|
errs = append(errs, fmt.Errorf("failed to parse file mode %q: %w", v, err))
|
|
return nil, errs
|
|
}
|
|
|
|
if mode < 1 || mode > int64(^uint32(0)) {
|
|
errs = append(errs, fmt.Errorf("%q must be in the range (%d - %d), got %d", v, 1, ^uint32(0), mode))
|
|
return nil, errs
|
|
}
|
|
|
|
return []string{}, errs
|
|
},
|
|
)
|
|
}
|
|
|
|
// FileSize is a schema validation function for file size.
|
|
func FileSize() schema.SchemaValidateDiagFunc {
|
|
return validation.ToDiagFunc(func(i interface{}, k string) ([]string, []error) {
|
|
v, ok := i.(string)
|
|
|
|
var es []error
|
|
|
|
if !ok {
|
|
es = append(es, fmt.Errorf("expected type of %s to be string", k))
|
|
return nil, es
|
|
}
|
|
|
|
if v != "" {
|
|
_, err := types.ParseDiskSize(v)
|
|
if err != nil {
|
|
es = append(es, fmt.Errorf("expected %s to be a valid file size (100, 1M, 1G), got %s", k, v))
|
|
return nil, es
|
|
}
|
|
}
|
|
|
|
return []string{}, es
|
|
})
|
|
}
|