mirror of
https://github.com/bpg/terraform-provider-proxmox.git
synced 2025-07-01 02:52:58 +00:00
cc9d0e7131
* feat(file): Add support to set the file mode GH-733 [1] implemented basic support for hook scripts, but the authors "did not manage to find time to work on" [2] also including support to set the file mode. This small but important feature makes the use of the `proxmox_virtual_environment_container.hook_script_file_id` [3] and `virtual_environment_vm.hook_script_file_id` [34] attributes basically useless when not combined with the manual step of making the uploaded file executable (manually running `chmod +x /path/to/script` or using other methods, based on the storage backend). Using the `hook_script_file_id` on its own also causes all planned and applies changes in the same execution to not be saved in the state because the Proxmox VE API responses with a HTTP `500` because the uploaded and assigned file is not executable. This pull request implements the missing feature to set the file mode by adding a new `file_mode` attribute of type `string` where an octal-formatted value can be passed, e.g. `0700` or only `600`. Note that the support for the octal prefixes `0o` and `0x` are not supported to reduced the complexity, even though Go of course support it, including the used `os.FileMode` type [5]. Changing the file mode also causes the file to be replaced, which is true for almost any attribute in the `proxmox_virtual_environment_file` resource, to ensure that the file mode can also be changed after the initial creation. [1]: https://github.com/bpg/terraform-provider-proxmox/pull/733 [2]: https://github.com/bpg/terraform-provider-proxmox/pull/733#issuecomment-2096716738 [3]: https://registry.terraform.io/providers/bpg/proxmox/latest/docs/resources/virtual_environment_container#hook_script_file_id [4]: https://registry.terraform.io/providers/bpg/proxmox/latest/docs/resources/virtual_environment_vm#hook_script_file_id [5]: https://pkg.go.dev/os#FileMode Related to GH-570 Related to GH-733 Signed-off-by: Sven Greb <development@svengreb.de> --------- Signed-off-by: Sven Greb <development@svengreb.de>
80 lines
1.7 KiB
Go
80 lines
1.7 KiB
Go
/*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
package validators
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestFileID(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
value string
|
|
valid bool
|
|
}{
|
|
{"empty", "", true},
|
|
{"invalid", "invalid", false},
|
|
{"valid", "local:vztmpl/zen-dns-0.1.tar.zst", true},
|
|
{"valid when datastore name has dots", "terraform.proxmox.storage.compute.zen:vztmpl/zen-dns-0.1.tar.zst", true},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
f := FileID()
|
|
res := f(tt.value, nil)
|
|
|
|
if tt.valid {
|
|
require.Empty(t, res, "validate: '%s'", tt.value)
|
|
} else {
|
|
require.NotEmpty(t, res, "validate: '%s'", tt.value)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFileMode(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
value string
|
|
valid bool
|
|
}{
|
|
{"valid", "0700", true},
|
|
{"invalid", "invalid", false},
|
|
// Even though Go supports octal prefixes, we should not allow them in the string value to reduce the complexity.
|
|
{"invalid", "0o700", false},
|
|
{"invalid", "0x700", false},
|
|
// Maximum value for uint32, incremented by one.
|
|
{"too large", "4294967296", false},
|
|
{"too small", "0", false},
|
|
{"negative", "-1", false},
|
|
{"empty", "", false},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
f := FileMode()
|
|
res := f(tt.value, nil)
|
|
|
|
if tt.valid {
|
|
require.Empty(t, res, "validate: '%s'", tt.value)
|
|
} else {
|
|
require.NotEmpty(t, res, "validate: '%s'", tt.value)
|
|
}
|
|
})
|
|
}
|
|
}
|