Sven Greb
76c1c2282b
feat(cluster): Implement initial support for "hardware mappings" ( #1213 )
...
* feat(cluster): Implement initial support for "hardware mappings"
Right now it is alredy possible to use a mapped resource [1], but there
is no dedicated `proxmox_virtual_environment_cluster_hardware_mapping`
resource but this step must still be done manually (or automated through
other ways that interact with the Proxmox API).
This commit implements support for "hardware mapping" resources and data
sources for the, currently, available bus types PCI and USB, based on
the Proxmox VE API documentations [2].
There are some "specialities" in these resources and data sources:
1. The Proxmox VE API attribute, but this implementations names it
"comment" since this naming is generally across the Proxmox VE web UI
and API documentations. This still follows the Terraform
"best practices" [3] as it improves the user experience by matching
the field name to the naming used in the human-facing interfaces.
2. Like in point 1, the name of the attribute of "node checks
diagnostics" for USB hardware mappings is "errors" in the Proxmox VE
API while it is "checks" for hardware mappings of type PCI.
The second naming pattern is also generally used across the
Proxmox VE web UI and API documentations, including the "check_node"
attribute that is also implemented in the
"proxmox_virtual_environment_hardware_mappings" data source.
Therefore, this implementation named both attributes "checks" which
still follows the Terraform "best practices" [3] as it improves the
user experience by matching the field name to the naming used in the
human-facing interfaces.
3. This implmenetation comes with the "unique" feature of allowing
comments (named "descriptions" by the Proxmox VE API) for an entry in
a device map which is not possible through the web UI at all but only
adding a comment for the whole mapping entry instead.
Note that this implementation also adds another point in the
"Known Issues" documentation since it is only possible to map a
PCI/USB device using the `root` PAM account, but this is still better
than having to manually configure it through the web UI or by
interacting with the Proxmox VE API on other ways.
[1]: https://github.com/bpg/terraform-provider-proxmox/pull/500
[2]: https://pve.proxmox.com/pve-docs/api-viewer/#/cluster/mapping/pci
[3]: https://developer.hashicorp.com/terraform/plugin/best-practices/hashicorp-provider-design-principles#resource-and-attribute-schema-should-closely-match-the-underlying-api
Signed-off-by: Sven Greb <development@svengreb.de>
* fix linter
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
---------
Signed-off-by: Sven Greb <development@svengreb.de>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-18 16:00:51 -04:00
Pavel Boldyrev
163a773088
chore(code): reorganize HA & node network code ( #1218 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-16 00:08:14 +00:00
renovate[bot]
1bf3bf0f68
chore(deps): update tools ( #1216 )
...
| datasource | package | from | to |
| -------------- | ------------------------------------------ | ------- | ------- |
| go | github.com/hashicorp/terraform-plugin-docs | v0.18.0 | v0.19.0 |
| golang-version | go | 1.22.0 | 1.22.2 |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-15 16:46:35 -04:00
Pavel Boldyrev
ad036a67e8
fix(vm): state drift due to disk re-ordering ( #1215 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-15 16:45:38 -04:00
bpg-autobot[bot]
8d1a5415ae
chore(main): release 0.53.1 ( #1208 )
...
Co-authored-by: bpg-autobot[bot] <155200059+bpg-autobot[bot]@users.noreply.github.com>
2024-04-11 23:19:17 -04:00
Pavel Boldyrev
628d0f15dd
fix(vm): regression: force VM recreation due to initialization.upgrade when it is not in the plan ( #1209 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-12 03:13:29 +00:00
allcontributors[bot]
9b06405157
docs: add tyxieblub as a contributor for code ( #1210 )
...
* docs: update CONTRIBUTORS.md
* docs: update .all-contributorsrc
---------
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2024-04-11 23:11:40 -04:00
joris
46d323d31b
fix(vm): error 'resizing of efidisks is not supported' when clonning a VM with re-defined efi_disk ( #1206 )
...
* fix(vm): compare efiType value instead of address
Signed-off-by: tyxieblub <5111464+tyxieblub@users.noreply.github.com>
* update example to reproduce the error case
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
---------
Signed-off-by: tyxieblub <5111464+tyxieblub@users.noreply.github.com>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-11 23:09:56 -04:00
dependabot[bot]
19a13bee0a
chore(deps): bump github.com/sigstore/cosign/v2 from 2.2.3 to 2.2.4 in /tools ( #1207 )
...
chore(deps): bump github.com/sigstore/cosign/v2 in /tools
Bumps [github.com/sigstore/cosign/v2](https://github.com/sigstore/cosign ) from 2.2.3 to 2.2.4.
- [Release notes](https://github.com/sigstore/cosign/releases )
- [Changelog](https://github.com/sigstore/cosign/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sigstore/cosign/compare/v2.2.3...v2.2.4 )
---
updated-dependencies:
- dependency-name: github.com/sigstore/cosign/v2
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-11 21:13:04 -04:00
bpg-autobot[bot]
8187d2eaea
chore(main): release 0.53.0 ( #1193 )
...
Co-authored-by: bpg-autobot[bot] <155200059+bpg-autobot[bot]@users.noreply.github.com>
2024-04-10 22:40:58 -04:00
Pavel Boldyrev
59972dc1b5
feat(vm): add support for initialization.upgrade attribute ( #1203 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-10 23:43:39 +00:00
Pavel Boldyrev
8515be686c
misc: do not auto-dispatch acceptance tests
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-09 22:39:10 -04:00
renovate[bot]
ead36dcafb
chore(deps): update golang.org/x/exp digest (c0f41cb → 93d18d7) ( #1201 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-10 02:12:52 +00:00
Pavel Boldyrev
c14b7ebe1d
chore(docs): minor documentation updates ( #1200 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-10 02:07:22 +00:00
Pavel Boldyrev
ae88cf603d
fix(firewall): remove strict validation for rule.iface attribute ( #1199 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-10 01:46:53 +00:00
Pavel Boldyrev
b4174a7c82
fix(vm): panic if initialization.user_account_keys contains null ( #1197 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-09 02:48:07 +00:00
Pavel Boldyrev
c27311183a
fix(vm): panic if numa block is empty ( #1196 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-09 02:35:25 +00:00
Pavel Boldyrev
c772fb3cf6
chore: refactor acceptance tests ( #1195 )
...
* misc: refactor acceptance tests
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
* moar refactoring
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
* fix cleanup in TestAccResourceFile
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
---------
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-09 02:01:32 +00:00
allcontributors[bot]
119fc8ad76
docs: add TheDevMinerTV as a contributor for code ( #1194 )
...
* docs: update CONTRIBUTORS.md
* docs: update .all-contributorsrc
---------
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2024-04-08 21:50:33 -04:00
DevMiner
f0a7afa57d
impl(proxmoxtf): Intel E1000E support ( #1191 )
...
Signed-off-by: DevMiner <devminer@devminer.xyz>
2024-04-08 20:35:58 -04:00
bpg-autobot[bot]
a1058f4633
chore(main): release 0.52.0 ( #1189 )
...
Co-authored-by: bpg-autobot[bot] <155200059+bpg-autobot[bot]@users.noreply.github.com>
2024-04-07 22:03:27 -04:00
Pavel Boldyrev
268c861649
chore: improve acceptance tests on CI ( #1173 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-07 04:41:57 +00:00
renovate[bot]
24daca5941
chore(ci): update actions/create-github-app-token action (v1.9.2 → v1.9.3) ( #1190 )
...
| datasource | package | from | to |
| ----------- | ------------------------------- | ------ | ------ |
| github-tags | actions/create-github-app-token | v1.9.2 | v1.9.3 |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-07 04:06:21 +00:00
renovate[bot]
f4e5ef8aaa
chore(deps): update tools ( #1184 )
...
* chore(ci): update actions/create-github-app-token action (v1.9.2 → v1.9.3)
| datasource | package | from | to |
| ----------- | ------------------------------- | ------ | ------ |
| github-tags | actions/create-github-app-token | v1.9.2 | v1.9.3 |
* chore(deps): update tools
| datasource | package | from | to |
| ---------- | ------------------------------------------------------------- | ------- | ------- |
| go | github.com/goreleaser/goreleaser | v1.24.0 | v1.25.1 |
| go | go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp | v0.49.0 | v0.50.0 |
* fix go.mod
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
---------
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-06 16:39:15 -04:00
Serge
dbbd966736
feat(vm): add support for numa architecture attribute ( #1156 ) ( #1175 )
...
* feat(vm): add support for numa architecture attribute (#1156 )
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
* fix: numa blocks reordering issue
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
---------
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-06 16:30:13 -04:00
Pavel Boldyrev
31b6812ce2
fix(vm): regression: provider always tries to update memory.*hugepages even if it is not specified ( #1188 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-06 12:27:55 +00:00
bpg-autobot[bot]
c1c4cf159b
chore(main): release 0.51.1 ( #1178 )
...
Co-authored-by: bpg-autobot[bot] <155200059+bpg-autobot[bot]@users.noreply.github.com>
2024-04-04 19:53:55 -04:00
renovate[bot]
e680aa9318
chore(deps): update golang.org/x/exp digest (a685a6e → c0f41cb) ( #1183 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-04 19:49:24 -04:00
Pavel Boldyrev
82d435f575
fix(vm): regressions: provider always tries to update cpu.affinity even if it is not specified ( #1182 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-04-04 23:48:49 +00:00
allcontributors[bot]
39e67da544
docs: add batonogov as a contributor for bug ( #1181 )
...
* docs: update CONTRIBUTORS.md
* docs: update .all-contributorsrc
---------
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2024-04-04 19:41:26 -04:00
renovate[bot]
7358257dba
chore(ci): update actions/create-github-app-token action (v1.9.0 → v1.9.2) ( #1177 )
...
| datasource | package | from | to |
| ----------- | ------------------------------- | ------ | ------ |
| github-tags | actions/create-github-app-token | v1.9.0 | v1.9.2 |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-03 00:05:14 +00:00
bpg-autobot[bot]
13b25df005
chore(main): release 0.51.0 ( #1154 )
...
Co-authored-by: bpg-autobot[bot] <155200059+bpg-autobot[bot]@users.noreply.github.com>
2024-03-30 08:20:13 -04:00
renovate[bot]
02efdc40bf
chore(deps): update module github.com/golangci/golangci-lint (v1.57.1 → v1.57.2) in /tools ( #1172 )
...
* chore(ci): update actions/create-github-app-token action (v1.9.0 → v1.9.1)
| datasource | package | from | to |
| ----------- | ------------------------------- | ------ | ------ |
| github-tags | actions/create-github-app-token | v1.9.0 | v1.9.1 |
* chore(deps): update module github.com/golangci/golangci-lint (v1.57.1 → v1.57.2) in /tools
| datasource | package | from | to |
| ---------- | --------------------------------- | ------- | ------- |
| go | github.com/golangci/golangci-lint | v1.57.1 | v1.57.2 |
* fix linter errors
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
---------
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-03-30 03:32:08 +00:00
renovate[bot]
e60ee990fa
chore(deps): update golang.org/x/exp digest (a85f2c6 → a685a6e) ( #1171 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-29 23:31:02 -04:00
Leah
e87bc4b941
fix: prevent authenticating multiple times in parallel ( #1168 )
...
Signed-off-by: hrmny <8845940+ForsakenHarmony@users.noreply.github.com>
2024-03-27 18:27:07 -04:00
Serge
a2f055a916
feat(vm): add support for memory hugepages and keep_hugepages attributes ( #1158 )
...
Allow use hugepages on the VM.
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
2024-03-27 18:13:03 -04:00
allcontributors[bot]
016fe49cc1
docs: add michaelfranzl as a contributor for code, and test ( #1164 )
...
* docs: update CONTRIBUTORS.md
* docs: update .all-contributorsrc
---------
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2024-03-26 01:24:42 +00:00
Michael Franzl
d41463de79
fix(vm): re-use ide, sata, and scsi cloud-init storage ( #1083 ) ( #1141 )
...
* fix(vm): add failing acceptance test for cloud-init over scsi interface (#1083 )
Signed-off-by: Michael Franzl <michael@franzl.name>
* fix(vm): re-use ide, sata, and scsi initialization storage (#1083 )
Signed-off-by: Michael Franzl <michael@franzl.name>
* fix linter error
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
---------
Signed-off-by: Michael Franzl <michael@franzl.name>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-03-25 21:23:10 -04:00
renovate[bot]
e5ef91e72d
chore(deps): update module github.com/hashicorp/terraform-plugin-framework (v1.6.1 → v1.7.0) ( #1150 )
...
| datasource | package | from | to |
| ---------- | ----------------------------------------------- | ------ | ------ |
| go | github.com/hashicorp/terraform-plugin-framework | v1.6.1 | v1.7.0 |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-26 01:09:25 +00:00
renovate[bot]
48756b69ba
chore(deps): update module github.com/golangci/golangci-lint (v1.56.2 → v1.57.1) in /tools ( #1149 )
...
* chore(deps): update module github.com/golangci/golangci-lint (v1.56.2 → v1.57.1) in /tools
| datasource | package | from | to |
| ---------- | --------------------------------- | ------- | ------- |
| go | github.com/golangci/golangci-lint | v1.56.2 | v1.57.1 |
* fix linter errors
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
---------
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-03-25 21:06:06 -04:00
allcontributors[bot]
72b7b3678b
docs: add soubinan as a contributor for code ( #1162 )
...
* docs: update CONTRIBUTORS.md
* docs: update .all-contributorsrc
---------
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2024-03-24 21:17:28 -04:00
Soubinan KACOU
c45e3367e7
fix(lxc): improve configurable timeouts for containers operations ( #1161 )
...
feat(lxc): Improve configurable timeouts for containers operations
Fix timeouts on CT creation (related to #1160 )
Add configurable timeout for CT start
Signed-off-by: Soubinan <contact@soubinan.tk>
Co-authored-by: Soubinan <contact@soubinan.tk>
2024-03-24 21:15:40 -04:00
allcontributors[bot]
3020e56bed
docs: add sergelogvinov as a contributor for code ( #1155 )
...
* docs: update CONTRIBUTORS.md
* docs: update .all-contributorsrc
---------
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2024-03-23 21:36:43 -04:00
Serge
83a5971cf6
feat(vm): add support for cpu affinity attribute ( #1148 ) ( #1153 )
...
* feat(vm): add support for cpu `affinity` attribute (#1148 )
It helps to pin VMs to the special cpu.
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
* add clarification about the format and permission requirements for `affinity`
* do not add `affinity` property to the API call if is not set
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
---------
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-03-23 21:34:59 -04:00
Serge
9fee8c1e2e
feat(vm): add proxmox_virtual_environment_node datasource ( #1151 )
...
* feat(vm): add proxmox_virtual_environment_node datasource
It helps to get CPU model, number of cores and sockets.
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
* fix node_name ref
* add acceptance test
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
---------
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-03-23 20:17:09 -04:00
bpg-autobot[bot]
1530fa3f48
chore(main): release 0.50.0 ( #1128 )
...
Co-authored-by: bpg-autobot[bot] <155200059+bpg-autobot[bot]@users.noreply.github.com>
2024-03-20 23:28:50 -04:00
Pavel Boldyrev
84440d8329
feat(lxc): add configurable timeout for container creation ( #1146 )
...
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
2024-03-21 03:02:26 +00:00
allcontributors[bot]
b366b2c9d5
docs: add soubinan as a contributor for bug ( #1145 )
...
* docs: update CONTRIBUTORS.md
* docs: update .all-contributorsrc
---------
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2024-03-20 22:58:57 -04:00
dependabot[bot]
f4c80ad297
chore(deps): bump github.com/docker/docker from 24.0.7+incompatible to 24.0.9+incompatible in /tools ( #1142 )
...
chore(deps): bump github.com/docker/docker in /tools
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 24.0.7+incompatible to 24.0.9+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Commits](https://github.com/docker/docker/compare/v24.0.7...v24.0.9 )
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-20 22:30:43 -04:00
allcontributors[bot]
5046fab04b
docs: add msdnna as a contributor for code ( #1144 )
...
* docs: update CONTRIBUTORS.md
* docs: update .all-contributorsrc
---------
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2024-03-20 22:23:29 -04:00
