mirror of
https://github.com/bpg/terraform-provider-proxmox.git
synced 2025-06-30 02:31:10 +00:00
* chore: fix a pair of typos in comments * feat(api): list High Availability groups * New clients created for HA and HA groups (via `Cluster().HA().Groups()`) * `List(ctx)` method that lists the cluster's High Availability groups * feat(ha): added the `proxmox_virtual_environment_hagroups` data source * This data source returns the list of HA groups in its value's `group_ids` field * fix(api): changed incorrect copy-pasted error message * feat(api): get a HA group's full information * Added a `Get()` method to the HA group client, which fetches a single group's information based on its identifier. * feat(ha): added the `proxmox_virtual_environment_hagroup` data source * This data source can read information about a single Proxmox High Availabillity group from the cluster. * chore(ha): fixed linter error * test(ha): added schema tests for the HA groups data sources * fix(ha): use -1 as a node's priority when no priority is defined * It used to default to 0, which is a valid value for priorities. * chore(ha): converted the `hagroups` datasource to the Terraform plugin SDK * chore(refactoring): common definition for `id` attributes * chore(ha): ported the HA group datasource to the Terraform plugin framework * feat(ha): return HA group identifiers as a set rather than a list * docs(ha): added examples for the hagroups/hagroup datasources * docs(ha): added documentation for the hagroup{,s} datasources * chore(ha): fixed linter errors * chore(ha): workaround for the linter's split personality disorder * fix(ha): fixed reading the restricted flag * chore(refactoring): use `ExpandPath` for paths to the HA groups API Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com> * feat: CustomBool to Terraform attribute value conversion method * chore(refactoring): use `CustomBool` for boolean fields in the API data * chore(refactoring): renamed "members" to "nodes" in the HA group datasource * fix: typo in comment * chore(refactoring): split HA group API data and added the update request body * fix(api): fixed copy-pasted error message * feat(api): method to create/update a HA group * feat(api): HA group deletion method * fix(api): made the digest optional for HA groups * feat(ha): added unimplemented hagroup resource * fix(ha): fixed copy-pasted comment * feat(ha): schema definition for the HA group resource * feat: helper function that converts string attr values to string pointers * fix(ha): ensure node priorities are <= 1000 in HA groups * fix(ha): add the digest attribute to the schema * feat(ha): model definition for the HA group resource * fix(api): fixed incorrect error message * fix(api): fixed HA group creation / update * I had somehow misunderstood the Proxmox API doc and thought creation and update went through the same endpoint. This has been fixed by adding separate data structures and separate methods for both actions. * feat: Terraform/Proxmox API conversion utilities * chore(refactoring): HA group model and reading code moved to separate file * feat(ha): HA group creation * fix(api): renamed method (missed during previous refactor) * feat(ha): `Read()` method implemented for the `hagroup` resource * chore(refactoring): more consistent variable naming * fix(ha): fixed the behaviour of `Read()` when the resource is deleted externally * feat(ha): implement HA group deletion * feat(ha): HA group update implemented * fix(ha): prevent empty or untrimmed HA group comments * feat(ha): HA group import * docs(ha): HA group resource examples * docs(ha): generated documentation for the `hagroup` resource * chore(ha): fixed linter errors * chore(refactoring): updated the code based on changes to the datasource PR * fix(api): fixed boolean fields in the HA group create/update structures * fix(ha): removed digest from the HA group resource and datasource * The digest is generated by Proxmox from the *whole* HA groups configuration, so any update to one group causes changes in all other groups. * Because of that, using it causes failures when updating two or more HA groups. * It is also a pretty useless value to have in the datasource, as it is global and not actually related to the individual data items * chore(refactoring): removed obsolete type conversion code * chore(refactoring): use `ExpandPath` in the HA groups API client * feat(ha): custom type for HA resource states * feat(ha): custom type for HA resource types * fix(api): fixed JSON decoding for HA resource states and types * Values were being decoded directly from the raw bytes. * Added tests for JSON marshaling/unmarshaling * feat(api): custom type for HA resource identifiers * Structure with a type and name * Conversion to/from strings * Marshaling to/Unmarshaling from JSON * URL encoding * feat(api): list and get HA resources * feat(ha): HA resources list datasource * feat(ha): added method that converts HA resource data to Terraform values * fix(api): HA resource max relocation/restarts are optional * feat(ha): Terraform validator for HA resource IDs * feat(ha): HA resource datasource * chore(refactoring): moved HA resource model to separate file * feat(api): data structures for HA resource creation and update * feat(api): HA resource creation, update and deletion * fix(api): incorrect mapping in common HA resource data * feat: utility function to create attribute validators based on parse functions * feat: validators for HA resource identifiers, states and types * fix(api): incorrect comment for the update request body * feat(ha): Terraform resource for Proxmox HA resources * chore(reafactoring): removed old HA resource ID validator * docs: examples related to HA resources added * docs: added documentation related to HA resources management * fix: update doc generation, fix minor typos * fix: rename & split utils package, replace `iota` --------- Co-authored-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
373 lines
11 KiB
Go
373 lines
11 KiB
Go
/*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
package cluster
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"regexp"
|
|
"strings"
|
|
|
|
"github.com/bpg/terraform-provider-proxmox/internal/structure"
|
|
customtypes "github.com/bpg/terraform-provider-proxmox/internal/types"
|
|
"github.com/bpg/terraform-provider-proxmox/proxmox"
|
|
haresources "github.com/bpg/terraform-provider-proxmox/proxmox/cluster/ha/resources"
|
|
|
|
"github.com/hashicorp/terraform-plugin-framework-validators/int64validator"
|
|
"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
|
|
"github.com/hashicorp/terraform-plugin-framework/diag"
|
|
"github.com/hashicorp/terraform-plugin-framework/resource"
|
|
"github.com/hashicorp/terraform-plugin-framework/resource/schema"
|
|
"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
|
|
"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringdefault"
|
|
"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
|
|
"github.com/hashicorp/terraform-plugin-framework/schema/validator"
|
|
"github.com/hashicorp/terraform-plugin-framework/tfsdk"
|
|
"github.com/hashicorp/terraform-plugin-framework/types"
|
|
)
|
|
|
|
// haresourceResource contains the resource's internal data.
|
|
type haresourceResource struct {
|
|
// The HA resources API client
|
|
client haresources.Client
|
|
}
|
|
|
|
// Ensure the resource implements the expected interfaces.
|
|
var (
|
|
_ resource.Resource = &haresourceResource{}
|
|
_ resource.ResourceWithConfigure = &haresourceResource{}
|
|
_ resource.ResourceWithImportState = &haresourceResource{}
|
|
)
|
|
|
|
// NewHAResourceResource returns a new resource for managing High Availability resources.
|
|
func NewHAResourceResource() resource.Resource {
|
|
return &haresourceResource{}
|
|
}
|
|
|
|
// Metadata defines the name of the resource.
|
|
func (r *haresourceResource) Metadata(
|
|
_ context.Context,
|
|
req resource.MetadataRequest,
|
|
resp *resource.MetadataResponse,
|
|
) {
|
|
resp.TypeName = req.ProviderTypeName + "_haresource"
|
|
}
|
|
|
|
// Schema defines the schema for the resource.
|
|
func (r *haresourceResource) Schema(
|
|
_ context.Context,
|
|
_ resource.SchemaRequest,
|
|
resp *resource.SchemaResponse,
|
|
) {
|
|
resp.Schema = schema.Schema{
|
|
Description: "Manages Proxmox HA resources.",
|
|
Attributes: map[string]schema.Attribute{
|
|
"id": structure.IDAttribute(),
|
|
"resource_id": schema.StringAttribute{
|
|
Description: "The Proxmox HA resource identifier",
|
|
Required: true,
|
|
Validators: []validator.String{
|
|
customtypes.HAResourceIDValidator(),
|
|
},
|
|
},
|
|
"state": schema.StringAttribute{
|
|
Description: "The desired state of the resource.",
|
|
Optional: true,
|
|
Computed: true,
|
|
Default: stringdefault.StaticString("started"),
|
|
Validators: []validator.String{
|
|
customtypes.HAResourceStateValidator(),
|
|
},
|
|
},
|
|
"type": schema.StringAttribute{
|
|
MarkdownDescription: "The type of HA resources to create. If unset, it will be deduced from the `resource_id`.",
|
|
Computed: true,
|
|
Optional: true,
|
|
Validators: []validator.String{
|
|
customtypes.HAResourceTypeValidator(),
|
|
},
|
|
PlanModifiers: []planmodifier.String{
|
|
stringplanmodifier.UseStateForUnknown(),
|
|
},
|
|
},
|
|
"comment": schema.StringAttribute{
|
|
Description: "The comment associated with this resource.",
|
|
Optional: true,
|
|
Validators: []validator.String{
|
|
stringvalidator.UTF8LengthAtLeast(1),
|
|
stringvalidator.RegexMatches(regexp.MustCompile(`^[^\s]|^$`), "must not start with whitespace"),
|
|
stringvalidator.RegexMatches(regexp.MustCompile(`[^\s]$|^$`), "must not end with whitespace"),
|
|
},
|
|
},
|
|
"group": schema.StringAttribute{
|
|
Description: "The identifier of the High Availability group this resource is a member of.",
|
|
Optional: true,
|
|
Validators: []validator.String{
|
|
stringvalidator.RegexMatches(
|
|
regexp.MustCompile(`^[a-zA-Z][a-zA-Z0-9\-_\.]*[a-zA-Z0-9]$`),
|
|
"must start with a letter, end with a letter or number, be composed of "+
|
|
"letters, numbers, '-', '_' and '.', and must be at least 2 characters long",
|
|
),
|
|
},
|
|
},
|
|
"max_relocate": schema.Int64Attribute{
|
|
Description: "The maximal number of relocation attempts.",
|
|
Optional: true,
|
|
Validators: []validator.Int64{
|
|
int64validator.Between(0, 10),
|
|
},
|
|
},
|
|
"max_restart": schema.Int64Attribute{
|
|
Description: "The maximal number of restart attempts.",
|
|
Optional: true,
|
|
Validators: []validator.Int64{
|
|
int64validator.Between(0, 10),
|
|
},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
// Configure adds the provider-configured client to the resource.
|
|
func (r *haresourceResource) Configure(
|
|
_ context.Context,
|
|
req resource.ConfigureRequest,
|
|
resp *resource.ConfigureResponse,
|
|
) {
|
|
if req.ProviderData == nil {
|
|
return
|
|
}
|
|
|
|
client, ok := req.ProviderData.(proxmox.Client)
|
|
if ok {
|
|
r.client = *client.Cluster().HA().Resources()
|
|
} else {
|
|
resp.Diagnostics.AddError(
|
|
"Unexpected Resource Configure Type",
|
|
fmt.Sprintf("Expected *proxmox.Client, got: %T. Please report this issue to the provider developers.",
|
|
req.ProviderData),
|
|
)
|
|
}
|
|
}
|
|
|
|
// Create creates a new HA resource.
|
|
func (r *haresourceResource) Create(ctx context.Context, req resource.CreateRequest, resp *resource.CreateResponse) {
|
|
var data haresourceModel
|
|
|
|
resp.Diagnostics.Append(req.Plan.Get(ctx, &data)...)
|
|
|
|
if resp.Diagnostics.HasError() {
|
|
return
|
|
}
|
|
|
|
resID, err := customtypes.ParseHAResourceID(data.ResourceID.ValueString())
|
|
if err != nil {
|
|
resp.Diagnostics.AddError(
|
|
"Unexpected error parsing Proxmox HA resource identifier",
|
|
fmt.Sprintf("Couldn't parse the Terraform resource ID into a valid HA resource identifier: %s. "+
|
|
"Please report this issue to the provider developers.", err),
|
|
)
|
|
|
|
return
|
|
}
|
|
|
|
createRequest := data.toCreateRequest(resID)
|
|
|
|
err = r.client.Create(ctx, createRequest)
|
|
if err != nil {
|
|
resp.Diagnostics.AddError(
|
|
fmt.Sprintf("Could not create HA resource '%v'.", resID),
|
|
err.Error(),
|
|
)
|
|
|
|
return
|
|
}
|
|
|
|
data.ID = types.StringValue(resID.String())
|
|
|
|
r.readBack(ctx, &data, &resp.Diagnostics, &resp.State)
|
|
}
|
|
|
|
// Update updates an existing HA resource.
|
|
func (r *haresourceResource) Update(
|
|
ctx context.Context,
|
|
req resource.UpdateRequest,
|
|
resp *resource.UpdateResponse,
|
|
) {
|
|
var data, state haresourceModel
|
|
|
|
resp.Diagnostics.Append(req.Plan.Get(ctx, &data)...)
|
|
resp.Diagnostics.Append(req.State.Get(ctx, &state)...)
|
|
|
|
if resp.Diagnostics.HasError() {
|
|
return
|
|
}
|
|
|
|
resID, err := customtypes.ParseHAResourceID(state.ID.ValueString())
|
|
if err != nil {
|
|
resp.Diagnostics.AddError(
|
|
"Unexpected error parsing Proxmox HA resource identifier",
|
|
fmt.Sprintf("Couldn't parse the Terraform resource ID into a valid HA resource identifier: %s. "+
|
|
"Please report this issue to the provider developers.", err),
|
|
)
|
|
|
|
return
|
|
}
|
|
|
|
updateRequest := data.toUpdateRequest(&state)
|
|
|
|
err = r.client.Update(ctx, resID, updateRequest)
|
|
if err == nil {
|
|
r.readBack(ctx, &data, &resp.Diagnostics, &resp.State)
|
|
} else {
|
|
resp.Diagnostics.AddError(
|
|
"Error updating HA resource",
|
|
fmt.Sprintf("Could not update HA resource '%s', unexpected error: %s",
|
|
state.Group.ValueString(), err.Error()),
|
|
)
|
|
}
|
|
}
|
|
|
|
// Delete deletes an existing HA resource.
|
|
func (r *haresourceResource) Delete(
|
|
ctx context.Context,
|
|
req resource.DeleteRequest,
|
|
resp *resource.DeleteResponse,
|
|
) {
|
|
var data haresourceModel
|
|
|
|
resp.Diagnostics.Append(req.State.Get(ctx, &data)...)
|
|
|
|
if resp.Diagnostics.HasError() {
|
|
return
|
|
}
|
|
|
|
resID, err := customtypes.ParseHAResourceID(data.ID.ValueString())
|
|
if err != nil {
|
|
resp.Diagnostics.AddError(
|
|
"Unexpected error parsing Proxmox HA resource identifier",
|
|
fmt.Sprintf("Couldn't parse the Terraform resource ID into a valid HA resource identifier: %s. "+
|
|
"Please report this issue to the provider developers.", err),
|
|
)
|
|
|
|
return
|
|
}
|
|
|
|
err = r.client.Delete(ctx, resID)
|
|
if err != nil {
|
|
if strings.Contains(err.Error(), "no such resource") {
|
|
resp.Diagnostics.AddWarning(
|
|
"HA resource does not exist",
|
|
fmt.Sprintf(
|
|
"Could not delete HA resource '%v', it does not exist or has been deleted outside of Terraform.",
|
|
resID,
|
|
),
|
|
)
|
|
} else {
|
|
resp.Diagnostics.AddError(
|
|
"Error deleting HA resource",
|
|
fmt.Sprintf("Could not delete HA resource '%v', unexpected error: %s",
|
|
resID, err.Error()),
|
|
)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Read reads the HA resource.
|
|
func (r *haresourceResource) Read(
|
|
ctx context.Context,
|
|
req resource.ReadRequest,
|
|
resp *resource.ReadResponse,
|
|
) {
|
|
var data haresourceModel
|
|
|
|
resp.Diagnostics.Append(req.State.Get(ctx, &data)...)
|
|
|
|
if resp.Diagnostics.HasError() {
|
|
return
|
|
}
|
|
|
|
found, diags := r.read(ctx, &data)
|
|
resp.Diagnostics.Append(diags...)
|
|
|
|
if !resp.Diagnostics.HasError() {
|
|
if found {
|
|
resp.Diagnostics.Append(resp.State.Set(ctx, data)...)
|
|
} else {
|
|
resp.State.RemoveResource(ctx)
|
|
}
|
|
}
|
|
}
|
|
|
|
// ImportState imports a HA resource from the Proxmox cluster.
|
|
func (r *haresourceResource) ImportState(
|
|
ctx context.Context,
|
|
req resource.ImportStateRequest,
|
|
resp *resource.ImportStateResponse,
|
|
) {
|
|
reqID := req.ID
|
|
data := haresourceModel{
|
|
ID: types.StringValue(reqID),
|
|
ResourceID: types.StringValue(reqID),
|
|
}
|
|
r.readBack(ctx, &data, &resp.Diagnostics, &resp.State)
|
|
}
|
|
|
|
// read reads information about a HA resource from the cluster. The Terraform resource identifier must have been set
|
|
// in the model before this function is called.
|
|
func (r *haresourceResource) read(ctx context.Context, data *haresourceModel) (bool, diag.Diagnostics) {
|
|
var diags diag.Diagnostics
|
|
|
|
resID, err := customtypes.ParseHAResourceID(data.ID.ValueString())
|
|
if err != nil {
|
|
diags.AddError(
|
|
"Unexpected error parsing Proxmox HA resource identifier",
|
|
fmt.Sprintf("Couldn't parse the Terraform resource ID into a valid HA resource identifier: %s. "+
|
|
"Please report this issue to the provider developers.", err),
|
|
)
|
|
|
|
return false, diags
|
|
}
|
|
|
|
resource, err := r.client.Get(ctx, resID)
|
|
if err != nil {
|
|
if !strings.Contains(err.Error(), "no such resource") {
|
|
diags.AddError("Could not read HA resource", err.Error())
|
|
}
|
|
|
|
return false, diags
|
|
}
|
|
|
|
data.importFromAPI(resource)
|
|
|
|
return true, nil
|
|
}
|
|
|
|
// readBack reads information about a created or modified HA resource from the cluster then updates the response
|
|
// state accordingly. It is assumed that the `state`'s identifier is set.
|
|
func (r *haresourceResource) readBack(
|
|
ctx context.Context,
|
|
data *haresourceModel,
|
|
respDiags *diag.Diagnostics,
|
|
respState *tfsdk.State,
|
|
) {
|
|
found, diags := r.read(ctx, data)
|
|
|
|
respDiags.Append(diags...)
|
|
|
|
if !found {
|
|
respDiags.AddError(
|
|
"HA resource not found after update",
|
|
"Failed to find the resource when trying to read back the updated HA resource's data.",
|
|
)
|
|
}
|
|
|
|
if !respDiags.HasError() {
|
|
respDiags.Append(respState.Set(ctx, *data)...)
|
|
}
|
|
}
|